Skip to content

Fix RepositoryConnection.getIsolationLevel() returning null when isolation level is set #5494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix RepositoryConnection.getIsolationLevel() returning null when isolation level is set #5494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1670ce0
Initial plan
Copilot Oct 5, 2025
c14c3a9
Fix SailRepositoryConnection to properly set isolation level in getIs…
Copilot Oct 5, 2025
7e14db1
Remove initial-evidence.txt file as requested
Copilot Oct 5, 2025
c0aaf78
Add test for getIsolationLevel() with default isolation level
Copilot Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...sitory/sail/src/main/java/org/eclipse/rdf4j/repository/sail/SailRepositoryConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,9 @@ public void begin() throws RepositoryException {
@Override
public void begin(IsolationLevel level) throws RepositoryException {
try {
// Call setIsolationLevel to update the AbstractRepositoryConnection's isolation level field
setIsolationLevel(level);

// always call receiveTransactionSettings(...) before calling begin();
sailConnection.setTransactionSettings();

Expand Down Expand Up @@ -195,6 +198,8 @@ public void begin(TransactionSetting... settings) {

for (TransactionSetting setting : settings) {
if (setting instanceof IsolationLevel) {
// Call setIsolationLevel to update the AbstractRepositoryConnection's isolation level field
setIsolationLevel((IsolationLevel) setting);
sailConnection.begin((IsolationLevel) setting);
return;
}
Expand Down
46 changes: 46 additions & 0 deletions ...ry/sail/src/test/java/org/eclipse/rdf4j/repository/sail/SailRepositoryConnectionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,16 @@
import java.util.Optional;

import org.eclipse.rdf4j.common.iteration.EmptyIteration;
import org.eclipse.rdf4j.common.transaction.IsolationLevel;
import org.eclipse.rdf4j.common.transaction.IsolationLevels;
import org.eclipse.rdf4j.query.BooleanQuery;
import org.eclipse.rdf4j.query.GraphQuery;
import org.eclipse.rdf4j.query.Query;
import org.eclipse.rdf4j.query.TupleQuery;
import org.eclipse.rdf4j.query.algebra.QueryRoot;
import org.eclipse.rdf4j.query.algebra.TupleExpr;
import org.eclipse.rdf4j.query.explanation.Explanation;
import org.eclipse.rdf4j.sail.Sail;
import org.eclipse.rdf4j.sail.SailConnection;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -169,4 +172,47 @@ public void testExplainQuery() {
anyBoolean(), anyInt());
}

@Test
public void testGetIsolationLevel_shouldReturnSetLevel() {
// Test that getIsolationLevel() returns the level set via begin(IsolationLevel)
assertThat(subject.getIsolationLevel()).isNull();

subject.begin(IsolationLevels.SERIALIZABLE);
assertThat(subject.getIsolationLevel()).isEqualTo(IsolationLevels.SERIALIZABLE);

subject.rollback();

subject.begin(IsolationLevels.READ_COMMITTED);
assertThat(subject.getIsolationLevel()).isEqualTo(IsolationLevels.READ_COMMITTED);

subject.rollback();
}

@Test
public void testGetIsolationLevel_shouldReturnSetLevelFromTransactionSettings() {
// Test that getIsolationLevel() returns the level set via begin(TransactionSetting...)
assertThat(subject.getIsolationLevel()).isNull();

subject.begin(IsolationLevels.READ_UNCOMMITTED);
assertThat(subject.getIsolationLevel()).isEqualTo(IsolationLevels.READ_UNCOMMITTED);

subject.rollback();
}

@Test
public void testGetIsolationLevel_shouldReturnDefaultLevelWhenNotExplicitlySet() {
// Test that getIsolationLevel() returns the default isolation level when begin() is called without parameters
assertThat(subject.getIsolationLevel()).isNull();

// Create a mock sail that returns the default isolation level
Sail mockSail = mock(Sail.class);
when(mockSail.getDefaultIsolationLevel()).thenReturn(IsolationLevels.READ_COMMITTED);
when(sailRepository.getSail()).thenReturn(mockSail);

subject.begin();
assertThat(subject.getIsolationLevel()).isEqualTo(IsolationLevels.READ_COMMITTED);

subject.rollback();
}

}
Loading