import: import log crate as baseline#18
import: import log crate as baseline#18pawelrutkaq wants to merge 2 commits intoeclipse-score:mainfrom
Conversation
9fb527d to
ae050e3
Compare
|
@hoppe-and-dreams @rmaddikery @arsibo The frontend was moved as requested. (FYI: @darkwisebear ) |
|
rmaddikery
left a comment
There was a problem hiding this comment.
Since the repo does not have all the checks in place please add in description if you follow Rust's naming convention and coding guidelines? E.g.: https://github.com/rust-lang/style-team/blob/master/guide/guide.md
I see few unit tests, but not covered for all. Is this planned?
https://doc.rust-lang.org/rust-by-example/testing.html
|
Follow ups plannned after this PR: For "imported" code, this is as is. As in above, this going to be fixed in MVP |
rmaddikery
left a comment
There was a problem hiding this comment.
A readme can be useful that demonstrates the usage and assumptions of use
As this is enabler from open source, no UT planned for this code. Only for new MVP providing proper frontend. |
score/mw/log/rust/Cargo.toml
Outdated
| name = "mw_log" | ||
| version = "0.0.1" | ||
| authors = ["S-CORE"] | ||
| readme = "README.md" |
Quality and naming output: pawel@pawel-VirtualBox ~/qorix/repos/baselibs/score/mw/log/rust (pawelrutkaq_rust_log_frontend) $ cargo build So common pratices for Rust followed. |
ff6f931 to
e173ade
Compare
1d089e7 to
1278fde
Compare
Import from log crate 3aa1359e926a39f841791207d6e57e00da3e68e2 at https://github.com/rust-lang/log Signed-off-by: Pawel Rutka <pawel.rutka.ext@qorix.ai>
2ebf0a2 to
9d154b6
Compare
|
@darkwisebear @4og @arsibo This is now done the way we agreed on (https://github.com/orgs/eclipse-score/discussions/236#discussioncomment-14759725). Can we have last look and continue ? |
9d154b6 to
758617f
Compare
|
Managed to release score-crates so updated deps. |
|
Hi @pawelrutkaq, your change is merged in 8e017e0 and 64924b7. Thank you for contribution! |
Import from log crate 3aa1359e926a39f841791207d6e57e00da3e68e2 at https://github.com/rust-lang/log
This is as follow up to decision in CFG Logging: eclipse-score/inc_mw_log#6 (comment)
to enable Rust code with common frontend.
Please consider that this is only enabler (eclipse-score/inc_mw_log#5), and frontend will be done from scratch in S-CORE (however it will be macro compatible). The Rust binding to
C++ mw::logwill be located in newloggingrepo.