Skip to content

Comments

Add missing deps and update some#1

Merged
antonkri merged 1 commit intoeclipse-score:mainfrom
eclipse-impl:swp-231016
Jan 16, 2026
Merged

Add missing deps and update some#1
antonkri merged 1 commit intoeclipse-score:mainfrom
eclipse-impl:swp-231016

Conversation

@eclipse-impl
Copy link
Contributor

Issue: SWP-231016

Small adjustments on Bazel Module:

  • Set the module's name properly
  • Add Bazel deps
  • Adjust deps versions to reflect used versions

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: b2dec7d0-5e22-4513-b69a-cc95784a5a87
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (66 packages loaded, 9 targets configured)

Analyzing: target //:license-check (77 packages loaded, 9 targets configured)

Analyzing: target //:license-check (138 packages loaded, 2545 targets configured)

Analyzing: target //:license-check (144 packages loaded, 2698 targets configured)

Analyzing: target //:license-check (145 packages loaded, 2701 targets configured)

Analyzing: target //:license-check (147 packages loaded, 4705 targets configured)

Analyzing: target //:license-check (147 packages loaded, 4705 targets configured)

Analyzing: target //:license-check (147 packages loaded, 4705 targets configured)

INFO: Analyzed target //:license-check (148 packages loaded, 6640 targets configured).
[6 / 13] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local
[9 / 13] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 2 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 208.261s, Critical Path: 0.38s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

antonkri
antonkri previously approved these changes Jan 13, 2026
FScholPer
FScholPer previously approved these changes Jan 14, 2026
@FScholPer
Copy link

Please check copyright and formatting @eclipse-impl

@eclipse-impl
Copy link
Contributor Author

Please check copyright and formatting @eclipse-impl

Hello @FScholPer, just to understand it better. The problem is not introduced by this PR and it's our understanding that it should be solved with the next batch of source exports that we are preparing. Would it be OK to solve these issues with that batch, or do these checks prevent the merging and would have to be added to this PR, although it's not its original goal nor fault?

@eclipse-impl
Copy link
Contributor Author

eclipse-impl commented Jan 15, 2026

@antonkri and @FScholPer may I ask you to review again? The change from the last time is just the module's name: "score_config_management". I noticed that there were modules using hyphen and others underscore, and what I had found was "score-config_management" which is a mix of both. So I asked our representative and he said that the convention should be to always use underscore.
This has been, of course, updated also on the internal PR that is preparing an update to the open-sourced files.

@antonkri antonkri merged commit 5805580 into eclipse-score:main Jan 16, 2026
5 of 7 checks passed
antonkri pushed a commit that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants