-
Notifications
You must be signed in to change notification settings - Fork 21
Make everything use find_runfiles #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
MaximilianSoerenPollak
wants to merge
4
commits into
eclipse-score:main
from
qorix-group:MSP_use_find_runfiles
Closed
Make everything use find_runfiles #373
MaximilianSoerenPollak
wants to merge
4
commits into
eclipse-score:main
from
qorix-group:MSP_use_find_runfiles
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License Check Results🚀 The license check job ran with the Bazel command: bazel run //src:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
Change all 'os.getenv[RUNFILES]' to now use the find_runfiles file. This is in preperation for the rules_python upgrade which changes this implementation again.
509c04c to
6bea28d
Compare
AlexanderLanin
approved these changes
Jan 29, 2026
Contributor
Author
|
I would like to take the learnings from here (and use this as a base) and combine it with the PR that upgrades it into rules_python 1.5+. I don't think it makes sense to merge this for the couple days it will survive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Description
Change all 'os.getenv[RUNFILES]' to now use the find_runfiles file.
!! This is in preperation for the rules_python upgrade which changes this implementation again. !!
The PR to upgrade rules_python & other modules will be prepared right after.
🚨 Impact Analysis
✅ Checklist