Skip to content

Conversation

@MaximilianSoerenPollak
Copy link
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak commented Jan 29, 2026

📌 Description

Change all 'os.getenv[RUNFILES]' to now use the find_runfiles file.
!! This is in preperation for the rules_python upgrade which changes this implementation again. !!
The PR to upgrade rules_python & other modules will be prepared right after.

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

@github-actions
Copy link

github-actions bot commented Jan 29, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: ce3702c4-1e7d-4c4c-8927-ec6bd61b46e5
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (65 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (69 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (73 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (126 packages loaded, 932 targets configured)

Analyzing: target //src:license-check (130 packages loaded, 2070 targets configured)

Analyzing: target //src:license-check (133 packages loaded, 2407 targets configured)

Analyzing: target //src:license-check (138 packages loaded, 2456 targets configured)

Analyzing: target //src:license-check (141 packages loaded, 4466 targets configured)

Analyzing: target //src:license-check (142 packages loaded, 4590 targets configured)

INFO: Analyzed target //src:license-check (143 packages loaded, 4716 targets configured).
[11 / 13] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[12 / 13] Building src/license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 24.052s, Critical Path: 2.61s
INFO: 13 processes: 9 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

Change all 'os.getenv[RUNFILES]' to now use the find_runfiles file.
This is in preperation for the rules_python upgrade which changes this
implementation again.
@MaximilianSoerenPollak
Copy link
Contributor Author

I would like to take the learnings from here (and use this as a base) and combine it with the PR that upgrades it into rules_python 1.5+.

I don't think it makes sense to merge this for the couple days it will survive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants