Skip to content

Initial proposal for logging solution#1

Open
antonkri wants to merge 3 commits intomainfrom
bmw_logging
Open

Initial proposal for logging solution#1
antonkri wants to merge 3 commits intomainfrom
bmw_logging

Conversation

@antonkri
Copy link

No description provided.

antonkri and others added 3 commits February 10, 2025 14:26
Set copyright header used on score repo to be consistent.
Set copyright header used on score repo.
Copy link

@FScholPer FScholPer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please change the relationships to bmw (namespaces etc.)
  • Please remove codebeamer relationships
  • Please add necessary files like gitignore etc. (https://github.com/eclipse-score/module_template)
  • Documentation in readme is quite big and the question is if this should not be part of the handbook
  • How to build guideline missing
  • How to build the lib as there is no workspace or Module existing


## Requirements

The requirements are maintained in [Codebeamer](), and the high-level architecture is illustrated in the [Magic Draw diagram](:27112/collaborator/document/4ff2a028-8ac7-4f7a-b42e-dd90816fec81?viewId=a0683e3f-a47e-4269-9000-255abd14110a&viewType=model&sectionId=977f79a2-d84f-4932-9190-1e520cc3696b)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change that to squinx needs as codebeamer is not a s-core tool


## Motivation

You can find more information about the history and motivation for mw::log library in the [Motivation](</swh/ddad_platform/blob/master/aas/mw/log/README.md#motivation>).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be linked to handbook

The benefits of using `mw::log` are:

* Gives developers the full control over logging code.
* Resolves dependencies to the AUTOSAR `ara::log` interfaces.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does that mean? Autosar is not part of S-CORE


## Detailed Design

The Detailed Design for the `mw::log` implementation can be found under the [design](</swh/ddad_platform/blob/master/aas/mw/log/design/README.md>) directory.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here broken link


## Assumptions of use (AoUs)

The AoUs are maintained in [Codebeamer](/cb/share/f55e57bf89054000a975502375922db5)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken link

For this we provide an empty recorder.

```
bmw::mw::log::EmptyRecorder my_recorder{};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namespace bmw should be changed


```
bmw::mw::log::EmptyRecorder my_recorder{};
bmw::mw::test::SetLogRecorder(my_recorder);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

ignored in unit tests.

```c++
bmw::mw::log::EmptyRecorder my_recorder{};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove or replace namespace


```c++
const bmw::mw::log::LogHex8 log_hex_8{10};
bmw::mw::log::LogInfo() << "log_hex_8: " << log_hex_8;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here


```c++
const bmw::mw::log::LogHex8 log_hex_8{10};
bmw::mw::log::LogInfo() << "log_hex_8: " << log_hex_8;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants