Introduce separate data channels for each local service instance element#14
Open
mariuswbr wants to merge 2 commits intoeclipse-score:mainfrom
Open
Introduce separate data channels for each local service instance element#14mariuswbr wants to merge 2 commits intoeclipse-score:mainfrom
mariuswbr wants to merge 2 commits intoeclipse-score:mainfrom
Conversation
1c6ec6e to
8d40f56
Compare
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces separate data channels (IPC connections via Proxy/Skeleton pattern, using mw::com) between the gatewayd and the someipd for each local service instance element. A local service instance is an offered service by an application running on the same ECU as the daemons. One of its elements would then be either an event or a method (or field as a composition of those).
Therefore instead of having one single Skeleton reference for all LocalServiceInstance objects for data transmission from gatewayd to someipd, there are now multiple Skeletons as part of the LocalServiceInstance class, one for each element.
The split into multiple data channels is done to ensure freedom from interference to a certain degree.
Furthermore scalability is another factor. Most of the SOME/IP messages will not need the full size of roughly ~1500 bytes.
The counterpart, the remote service instances shall be refactored in a similar fashion as soon as the GenericSkeleton is available from mw::com.
Resolves #8 partially.