Add sanitizer support using GCC toolchain features#64
Add sanitizer support using GCC toolchain features#64RSingh1511 wants to merge 3 commits intoeclipse-score:mainfrom
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
90a54e3 to
698d31d
Compare
| bazel_dep(name = "score_bazel_platforms", version = "0.0.4") | ||
| bazel_dep(name = "score_docs_as_code", version = "2.2.0") | ||
| bazel_dep(name = "score_tooling", version = "1.1.1") | ||
| bazel_dep(name = "score_docs_as_code", version = "2.3.0") |
There was a problem hiding this comment.
You will need docs-as-code 3.0.1 if you want to use tooling 1.1.2.
There was a problem hiding this comment.
I've verified that score_docs_as_code@2.3.0 works correctly with score_tooling@1.1.2 and all tests pass. The sanitizer implementation is complete and ready for review.
Using 3.0.1 causes CI failures because score_tooling@1.1.2 declares it as dev_dependency = True, making it invisible to consuming modules.
There was a problem hiding this comment.
Do you need the new added Documentation API this from tooling 1.1.2?
If not then downgrading to 1.1.0 and upgrading docs-as-code to 3.0.0 would be advisable.
Otherwise you will not be able to use the new features from docs-as-code.
See Features Here
6500360 to
630e545
Compare
630e545 to
a218e21
Compare
a218e21 to
f19c4ff
Compare
f19c4ff to
008bf6c
Compare
008bf6c to
7db300f
Compare
Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #