fix: preserve program insertion order in OrchProgramManager#78
Closed
Lukasz-Juranek wants to merge 1 commit intoeclipse-score:mainfrom
Closed
fix: preserve program insertion order in OrchProgramManager#78Lukasz-Juranek wants to merge 1 commit intoeclipse-score:mainfrom
Lukasz-Juranek wants to merge 1 commit intoeclipse-score:mainfrom
Conversation
Replace `pop()` with `remove(0)` in both `into_program_manager()` and `Design::into_programs()` to process designs and programs in FIFO order instead of LIFO. This ensures programs maintain the order they were added via `add_program()`. Also fix the `TestGraphInSeparatePrograms` test to use the `integration_graph` scenario (which runs all programs) instead of `graph_program` (which only runs one), and remove the xfail marker since the bug is now fixed. Closes eclipse-score#60 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
into_program_manager()inapi/mod.rsusingpop()(LIFO) instead ofremove(0)(FIFO) when processing designs, causing reversed orderDesign::into_programs()inapi/design.rswhere programs within a design were also popped in reverse orderTestGraphInSeparateProgramstest to useintegration_graphscenario (runs all programs) instead ofgraph_program(runs only one)@pytest.mark.xfailmarker from the test since the bug is now fixedTest plan
bazel test //...— all 6 test targets PASS (including previously xfailTestGraphInSeparatePrograms::test_valid)bazel build //...— full build SUCCESSCloses #60
🤖 Generated with Claude Code