Skip to content

fix: remove dev_dependency flag from google_benchmark #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexanderLanin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove dev_dependency flag from google_benchmark #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ register_toolchains(
# Module dependencies
bazel_dep(name = "googletest", version = "1.17.0.bcr.1")

bazel_dep(name = "google_benchmark", version = "1.9.4", dev_dependency = True)
bazel_dep(name = "google_benchmark", version = "1.9.4")
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The google_benchmark dependency should include dev_dependency = True since it's only used for benchmarking tests (see src/cpp/tests/bm_kvs.cpp). This follows the same pattern as other test-only dependencies in this file like googletest, rules_python, rust, and score_toolchains_gcc. Without this flag, the benchmark library will be included in production builds unnecessarily, potentially increasing build times and binary sizes.

Suggested change
bazel_dep(name = "google_benchmark", version = "1.9.4")
bazel_dep(name = "google_benchmark", version = "1.9.4", dev_dependency = True)

Copilot uses AI. Check for mistakes.

## S-CORE bazel registry
bazel_dep(name = "score_tooling", version = "1.0.2")
Expand Down
Loading