KVS new Design by Ahmed-Elsaka-JC · Pull Request #172 · eclipse-score/persistency

Ahmed-Elsaka-JC · 2025-11-21T09:25:05Z

New Design for KVS

github-actions · 2025-11-21T09:28:56Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 91f940a2-faec-4e86-a8cd-416a35c2d9dd
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-oEubHgeZDdT0svMmBKJx7c3/2TdSI/vfwRUyDn+TPGA="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'score_process', the root module requires module version score_process@1.3.2, but got score_process@1.4.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
Loading: 3 packages loaded
    currently loading: 
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)

Analyzing: target //:license-check (83 packages loaded, 10 targets configured)

Analyzing: target //:license-check (89 packages loaded, 10 targets configured)

Analyzing: target //:license-check (150 packages loaded, 1454 targets configured)

Analyzing: target //:license-check (154 packages loaded, 4668 targets configured)

Analyzing: target //:license-check (157 packages loaded, 6753 targets configured)

Analyzing: target //:license-check (157 packages loaded, 6753 targets configured)

Analyzing: target //:license-check (160 packages loaded, 8763 targets configured)

Analyzing: target //:license-check (161 packages loaded, 8887 targets configured)

INFO: Analyzed target //:license-check (162 packages loaded, 9013 targets configured).
[10 / 14] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions, 1 running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 62 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[12 / 14] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
[13 / 14] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 35.850s, Critical Path: 2.61s
INFO: 14 processes: 9 internal, 4 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2025-11-21T09:31:33Z

The created documentation from the pull request is available at: docu-html

Design/NewDesign.dio

Design/Design_puml.puml

arkjedrz · 2025-12-18T11:46:21Z

Design/Design_puml.puml

+
+class IKvsBuilder <<implementation>> {
+    - instance_id: InstanceId
+    - need_defaults : bool


-> -defaults : KvsDefaults

Expected values :

true : default storage must be exist

false : default storage may not be exist

Ignores : ignore default values even if we have default values storage.

- new ticket should be created to make c++ support this as rust.

arkjedrz · 2025-12-18T11:46:34Z

Design/Design_puml.puml

+class IKvsBuilder <<implementation>> {
+    - instance_id: InstanceId
+    - need_defaults : bool
+    - need_kvs : bool


-> -kvs_load : KvsLoad

kvs_load = OpenNeedKvs :
OpenNeedKvs has two values now :
new value will be added "IGNORE"

new ticket should be created to make c++ support this as rust.

Design/Design_puml.puml

arkjedrz · 2025-12-18T11:53:04Z

Design/Design_puml.puml

+    + set_value(Key:string, value:KvsValue): ResultBlank
+    + remove_key(Key:string) : ResultBlank
+    + flush() : ResultBlank
+    + snapshot_count: Result<size_t>


This is a function.

@arkjedrz what is meant by this if a function ?

Design/Design_puml.puml

arkjedrz · 2025-12-18T11:55:52Z

Design/Design_puml.puml

Regarding names - please align with https://github.com/qorix-group/persistency/blob/e3945d4bea1bb3627dd46835db403b0c460306d1/docs/class_diagram.puml

tizava · 2025-12-18T13:13:05Z

Design/Design_puml.puml

Seems like this file is not included in any index file

Design/Design_puml.puml

docs/Design/class_diagram_cpp.puml

arkjedrz

I won't discuss this PR anymore until requested changes are fixed. We're running in circles.
Please first review this document internally.

docs/Design/class_diagram_cpp.puml

PiotrKorkus · 2026-01-27T13:28:57Z

@Ahmed-Elsaka-JC Could you rebase on top of newest upstream/main?

Docs are building in other PRs and there shouldn't be an error.

PiotrKorkus · 2026-01-27T13:30:20Z

docs/Design/class_diagram_cpp.puml

*.puml files itself will never be rendered. You need to reference it in any other .rst file as

.. uml:: class_diagram_cpp.puml

- class diagram represent new design of score kvs.

arkjedrz self-requested a review December 18, 2025 07:47

arkjedrz suggested changes Dec 18, 2025

View reviewed changes

tizava suggested changes Dec 18, 2025

View reviewed changes

Ahmed-Elsaka-JC changed the title ~~Draft~~ KVS new Design Jan 14, 2026

arkjedrz suggested changes Jan 20, 2026

View reviewed changes

Ahmed-Elsaka-JC marked this pull request as ready for review January 22, 2026 13:40

arkjedrz suggested changes Jan 27, 2026

View reviewed changes

docs/Design/class_diagram_cpp.puml Outdated Show resolved Hide resolved

PiotrKorkus reviewed Jan 27, 2026

View reviewed changes

Ahmed-Elsaka-JC requested review from PandaeDo and vinodreddy-g as code owners January 29, 2026 07:46

Ahmed-Elsaka-JC added 6 commits January 29, 2026 09:02

proposed new design

14e231d

new puml design

558cb58

update dio design

0e91d66

update class diagram for kvs

698e7ff

- class diagram represent new design of score kvs.

fix review points

f8831cf

fix review points

bccdd6a

Ahmed-Elsaka-JC force-pushed the afe_new_uml_model branch from 9ab1207 to bccdd6a Compare January 29, 2026 08:03

fix review points

868c5ca

Ahmed-Elsaka-JC requested a review from PiotrKorkus February 3, 2026 09:37

Conversation

Ahmed-Elsaka-JC commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ahmed-Elsaka-JC Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ahmed-Elsaka-JC Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ahmed-Elsaka-JC Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arkjedrz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PiotrKorkus commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Ahmed-Elsaka-JC commented Nov 21, 2025 •

edited

Loading

github-actions bot commented Nov 21, 2025 •

edited

Loading

Ahmed-Elsaka-JC Jan 8, 2026 •

edited

Loading

Ahmed-Elsaka-JC Jan 8, 2026 •

edited

Loading

Ahmed-Elsaka-JC Jan 8, 2026 •

edited

Loading

PiotrKorkus commented Jan 27, 2026 •

edited

Loading