Do not use default VIN#61
Merged
eriksven merged 2 commits intoeclipse-sdv-blueprints:mainfrom Apr 29, 2025
Merged
Conversation
The default VIN had been used when the Databroker did not contain a VIN (yet). This was often the case when the CSV provider did not report the VIN to the Databroker soon after startup but only later. This had the unwanted effect of two VINs showing up in the influxDB, the default VIN and (later) the real VIN as reported by the CSV provider. The FMS Forwarder has been changed to ignore data sets from the Databroker unless it contains a VIN.
eriksven
reviewed
Apr 29, 2025
| fms-forwarder: | ||
| command: "zenoh -c /zenoh-config.json5" | ||
| depends_on: | ||
| influxdb: |
Contributor
There was a problem hiding this comment.
Why did you remove this condition? Because if the database is not present there is no need to have the forwarder running.
Contributor
There was a problem hiding this comment.
Nevermind, in a real-world deployment the forwarder would not know directly about the state of the database in the backend either.
Contributor
Author
There was a problem hiding this comment.
That was my thinking as well ...
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default VIN had been used when the Databroker did not contain a
VIN (yet). This was often the case when the CSV provider did not
report the VIN to the Databroker soon after startup but only later.
This had the unwanted effect of two VINs showing up in the influxDB,
the default VIN and (later) the real VIN as reported by the CSV
provider.
The FMS Forwarder has been changed to ignore data sets from the
Databroker unless it contains a VIN.