-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4233] Add Cursor-based pagination in Project related GET REST APIs #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be rebased & reviewed after the merge of #4216 |
AxelRICHARD
force-pushed
the
ari/enh/pagination
branch
5 times, most recently
from
November 27, 2024 10:07
e5c5d89
to
8bb2436
Compare
1 task
AxelRICHARD
force-pushed
the
ari/enh/pagination
branch
3 times, most recently
from
December 10, 2024 08:21
9f6dac7
to
f66dac9
Compare
gcoutable
requested changes
Dec 11, 2024
packages/sirius-web/backend/sirius-web-application/src/main/resources/schema/siriusweb.graphqls
Show resolved
Hide resolved
AxelRICHARD
force-pushed
the
ari/enh/pagination
branch
from
December 24, 2024 13:05
f66dac9
to
9b7254f
Compare
AxelRICHARD
commented
Dec 24, 2024
...n/java/org/eclipse/sirius/web/application/project/controllers/ViewerProjectsDataFetcher.java
Outdated
Show resolved
Hide resolved
...end/sirius-web-application/src/views/project-browser/list-projects-area/ListProjectsArea.tsx
Outdated
Show resolved
Hide resolved
AxelRICHARD
force-pushed
the
ari/enh/pagination
branch
from
December 24, 2024 15:00
9b7254f
to
871da35
Compare
AxelRICHARD
commented
Dec 24, 2024
...end/sirius-web-application/src/views/project-browser/list-projects-area/ListProjectsArea.tsx
Outdated
Show resolved
Hide resolved
AxelRICHARD
force-pushed
the
ari/enh/pagination
branch
2 times, most recently
from
January 10, 2025 16:03
999f98e
to
59237cb
Compare
I still have issue:
It still displays 5 projects => KO (it should display more than 5 projects) |
Bug: #4233 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD
force-pushed
the
ari/enh/pagination
branch
from
January 13, 2025 15:52
59237cb
to
2994a91
Compare
Has been fixed |
gcoutable
approved these changes
Jan 13, 2025
Can be merged once the build has passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:
andpr:
labels been added to the pull request? (In case of doubt, start with the labelspriority: low
andpr: to review later
)area:
,difficulty:
,type:
)CHANGELOG.adoc
been updated to reference the relevant issues?CHANGELOG.adoc
? (Including changes in the GraphQL API)CHANGELOG.adoc
? For example indoc/screenshots/2022.5.0-my-new-feature.png
Architectural decision records (ADR)
[doc]
?CHANGELOG.adoc
?Dependencies
CHANGELOG.adoc
?CHANGELOG.adoc
?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
useState<STATE_TYPE>(…)
?.
(if the GraphQL API specifies that a field cannot benull
, do not treat it has potentiallynull
for example)let diagram: Diagram | null = null;
)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request