Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4233] Add Cursor-based pagination in Project related GET REST APIs #4237

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

AxelRICHARD
Copy link
Contributor

@AxelRICHARD AxelRICHARD commented Nov 26, 2024

Pull request template

General purpose

What is the main goal of this pull request?

  • Bug fixes
  • New features
  • Documentation
  • Cleanup
  • Tests
  • Build / releng

Project management

  • Has the pull request been added to the relevant project and milestone? (Only if you know that your work is part of a specific iteration such as the current one)
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, difficulty:, type:)
  • Have the relevant issues been added to the same project and milestone as the pull request?
  • Has the CHANGELOG.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc? (Including changes in the GraphQL API)
  • In case of a change with a visual impact, are there any screenshots in the CHANGELOG.adoc? For example in doc/screenshots/2022.5.0-my-new-feature.png

Architectural decision records (ADR)

  • Does the title of the commit contributing the ADR start with [doc]?
  • Are the ADRs mentioned in the relevant section of the CHANGELOG.adoc?

Dependencies

  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • Are the new dependencies justified in the CHANGELOG.adoc?

Frontend

This section is not relevant if your contribution does not come with changes to the frontend.

General purpose

  • Is the code properly tested? (Plain old JavaScript tests for business code and tests based on React Testing Library for the components)

Typing

We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).

  • Variables have a proper type
  • Functions’ arguments have a proper type
  • Functions’ return type are specified
  • Hooks are properly typed:
    • useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
    • useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
    • useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
    • useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
    • useState<STATE_TYPE>(…)
  • All components have a proper typing for their props
  • No useless optional chaining with ?. (if the GraphQL API specifies that a field cannot be null, do not treat it has potentially null for example)
  • Nullable values have a proper type (for example let diagram: Diagram | null = null;)

Backend

This section is not relevant if your contribution does not come with changes to the backend.

General purpose

  • Are all the event handlers tested?
  • Are the event processor tested?
  • Is the business code (services) tested?
  • Are diagram layout changes tested?

Architecture

  • Are data structure classes properly separated from behavioral classes?
  • Are all the relevant fields final?
  • Is any data structure mutable? If so, please write a comment indicating why
  • Are behavioral classes either stateless or side effect free?

Review

How to test this PR?

Please describe here the various use cases to test this pull request

  • Has the Kiwi TCMS test suite been updated with tests for this contribution?

@AxelRICHARD
Copy link
Contributor Author

To be rebased & reviewed after the merge of #4216

@AxelRICHARD AxelRICHARD force-pushed the ari/enh/pagination branch 5 times, most recently from e5c5d89 to 8bb2436 Compare November 27, 2024 10:07
@AxelRICHARD AxelRICHARD linked an issue Nov 27, 2024 that may be closed by this pull request
1 task
@AxelRICHARD AxelRICHARD force-pushed the ari/enh/pagination branch 3 times, most recently from 9f6dac7 to f66dac9 Compare December 10, 2024 08:21
@sbegaudeau sbegaudeau removed this from the 2025.1.0 milestone Dec 22, 2024
@AxelRICHARD AxelRICHARD added this to the 2025.2.0 milestone Dec 24, 2024
@AxelRICHARD AxelRICHARD force-pushed the ari/enh/pagination branch 2 times, most recently from 999f98e to 59237cb Compare January 10, 2025 16:03
@gcoutable
Copy link
Member

gcoutable commented Jan 13, 2025

I still have issue:

  1. Have more than five projects
  2. Go to the second page and go back to the first page
  3. Switch the number of displayed project from 5 to 10

It still displays 5 projects => KO (it should display more than 5 projects)

Bug: #4233
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
@gcoutable
Copy link
Member

I still have issue:

0. Have more than five projects

1. Go to the second page and go back to the first page

2. Switch the number of displayed project from 5 to 10

It still displays 5 projects => KO (it should display more than 5 projects)

Has been fixed

@gcoutable
Copy link
Member

Can be merged once the build has passed

@gcoutable gcoutable merged commit a9b2517 into master Jan 13, 2025
4 checks passed
@gcoutable gcoutable deleted the ari/enh/pagination branch January 13, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Pagination in Project related GET REST APIs
3 participants