Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4312] Update the Details view when its input is deselected #4314

Merged
merged 1 commit into from
Dec 16, 2024
Merged

[4312] Update the Details view when its input is deselected #4314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ This provider is in charge of getting the icon list of the representation.
This was first fixed in 2022.3.0 but broken in 2024.3.0; it is now fixed again.
- https://github.com/eclipse-sirius/sirius-web/issues/4280[#4280] [diagram] Fix direct edit with F2 when the palette is opened
- https://github.com/eclipse-sirius/sirius-web/issues/4302[#4302] [diagram] Fix edges label flashing
- https://github.com/eclipse-sirius/sirius-web/issues/4312[#4312] [sirius-web] The _Details_ view dit not react to its input is deselected, showing potentially stale information

=== New Features

Expand Down
2 changes: 1 addition & 1 deletion ...eb/frontend/sirius-web-application/src/views/edit-project/workbench-views/DetailsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export const DetailsView = ({ editingContextId, readOnly }: WorkbenchViewCompone

const { classes } = useDetailsViewStyles();

if (!state.form || complete) {
if (!state.form || complete || skip) {
return (
<div className={classes.idle}>
<Typography variant="subtitle2">No object selected</Typography>
Expand Down
Loading