Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added delete project feature at project landing page table #178

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Added delete project feature at project landing page table #178

merged 3 commits into from
Jan 18, 2024

Conversation

amritkv
Copy link
Contributor

@amritkv amritkv commented Nov 29, 2023

WIP : Added delete project feature at project landing page table

@GMishx GMishx added the WIP label Nov 30, 2023
@amritkv amritkv force-pushed the projects_landing_page branch 7 times, most recently from 1306652 to e52ed9d Compare December 4, 2023 09:17
@GMishx GMishx added needs codes review needs codes review needs general test needs general test and removed WIP labels Dec 4, 2023
@hoangnt2
Copy link
Contributor

hoangnt2 commented Dec 6, 2023 •
edited
Loading

Project version, number of releases, attachments and packages can not be shown on modal.
New GUI
image

Old GUI
image

@hoangnt2 hoangnt2 added the bug Something isn't working label Dec 6, 2023
@amritkv amritkv force-pushed the projects_landing_page branch from 0a186fd to 4236428 Compare December 11, 2023 05:46
@amritkv
Copy link
Contributor Author

amritkv commented Dec 11, 2023

Project version, number of releases, attachments and packages can not be shown on modal. New GUI image

Old GUI image

Hey @hoangnt2, Did I miss any discussion about this change ? Because, what I believe the modal shows related info before deleting the project. 🤔

@amritkv amritkv force-pushed the projects_landing_page branch 2 times, most recently from 33a9009 to a291180 Compare December 11, 2023 09:20
@hoangnt2
Copy link
Contributor

hoangnt2 commented Dec 12, 2023 •
edited
Loading

@amritkv, Sorry for confusing you. I mean related information must be shown like old GUI. But in new GUI, modal cannot display them. That is a bug.

@amritkv
Copy link
Contributor Author

amritkv commented Dec 12, 2023

@amritkv, Sorry for confusing you. I mean related information must be shown like old GUI. But in new GUI, modal cannot display them. That is a bug.

@hoangnt2 Yeah, but my question was about modal.

@hoangnt2
Copy link
Contributor

hoangnt2 commented Dec 12, 2023 •
edited
Loading

@hoangnt2 Yeah, but my question was about modal.

@amritkv Please keep the modal shows related info before deleting the project. I add bug label because when I tested your PR, I couldn't see related info in modal.
There is no problem with the spec, you just need to fix the bug

@amritkv
Copy link
Contributor Author

amritkv commented Dec 12, 2023 •
edited
Loading

@hoangnt2 Yeah, but my question was about modal.

@amritkv Please keep the modal shows related info before deleting the project. I add bug label because when I tested your PR, I couldn't see related info in modal. There is no problem with the spec, you just need to fix the bug

@hoangnt2 Ohh sorry, got it. It's clear now ! 👍
But just a small update, if any project does not have any such linked project, attachment or release, it will not show these details. It will just show whether you want to delete it. It will show only if the project contains these details. This is how existing GUI is.
I mean, if a project (say project-1)has say, no linked project, no linked release, no attachments then it will show like below :

image

But, if the project i.e. project-1 has 1 linked project, 1 linked release and 1 linked package it will show like below:

image

@hoangnt2
Copy link
Contributor

@amritkv, actually 2 photos above were taken with the same project, 1 with the old GUI and 1 with the new one. The new GUI couldn't show related info even though they exist.

@hoangnt2
Copy link
Contributor

Here is what I see in old GUI
image

Here is from new GUI
image

@amritkv
Copy link
Contributor Author

amritkv commented Dec 12, 2023

Here is what I see in old GUI image

Here is from new GUI image

@hoangnt2 Thanks for such a close observation. Le'me fix it. 😟

@amritkv
Copy link
Contributor Author

amritkv commented Dec 12, 2023

Project version, number of releases, attachments and packages can not be shown on modal. New GUI image

Old GUI image

@hoangnt2 bro, does projects has packages ? Or it is the attachments only ?

@hoangnt2
Copy link
Contributor

hoangnt2 commented Dec 12, 2023 •
edited
Loading

@hoangnt2 bro, does projects has packages ? Or it is the attachments only ?

@amritkv Yes, it has packages but no attachments.

Here is all related info that need to be shown
image

@amritkv
Copy link
Contributor Author

amritkv commented Dec 12, 2023

@hoangnt2 bro, does projects has packages ? Or it is the attachments only ?

@amritkv Yes, it has packages but no attachments.

Here is all related info that need to be shown image

@hoangnt2 Here I got the problem. Actually, in my local setup the packages for projects page is not deployed yet. That's why this issue has came up.
In my case for a project, I'm getting only linked projects, linked releases, and attachments. But not linked packages.
I am looking into it.

heliocastro
heliocastro previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@heliocastro heliocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heliocastro heliocastro self-requested a review December 21, 2023 14:25
@heliocastro
Copy link
Contributor

@amritkv Please resolve the conflicts

@amritkv
Copy link
Contributor Author

amritkv commented Dec 22, 2023

@amritkv Please resolve the conflicts

Sure !

@amritkv amritkv force-pushed the projects_landing_page branch 3 times, most recently from d824042 to 06167e3 Compare December 23, 2023 17:14
heliocastro
heliocastro previously approved these changes Dec 24, 2023
View reviewed changes
@amritkv amritkv force-pushed the projects_landing_page branch from 06167e3 to c4988f1 Compare January 18, 2024 03:34
@heliocastro heliocastro merged commit 9b3c594 into eclipse-sw360:main Jan 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heliocastro heliocastro heliocastro approved these changes

@hoangnt2 hoangnt2 Awaiting requested review from hoangnt2 hoangnt2 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working needs codes review needs codes review needs general test needs general test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amritkv @hoangnt2 @heliocastro @GMishx