Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix page styling and component error, hide locale prefix from URL #179

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Fix page styling and component error, hide locale prefix from URL #179

merged 2 commits into from
Nov 30, 2023

Conversation

hoangnt2
Copy link
Contributor

@hoangnt2 hoangnt2 commented Nov 30, 2023 •
edited
Loading

This PR does several things:

  • Fix some global css not working.
  • Align page content
  • Hide locales prefix (en, ja, ...) from URL
  • Fix bug prop's value is undefined for AddAdditionalRoles

@hoangnt2 hoangnt2 requested a review from heliocastro November 30, 2023 07:18
@hoangnt2 hoangnt2 merged commit 947545c into eclipse-sw360:main Nov 30, 2023
2 checks passed
heliocastro
heliocastro approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@heliocastro heliocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Hide the language endpoints was a good idea

@hoangnt2 hoangnt2 deleted the release/fix-page-styling-and-component-error branch November 30, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heliocastro heliocastro heliocastro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoangnt2 @heliocastro