Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Navbar): Fix bug cannot click navbar items in production mode #221

Merged
merged 1 commit into from
Feb 21, 2024
Merged

fix(Navbar): Fix bug cannot click navbar items in production mode #221

merged 1 commit into from
Feb 21, 2024

Conversation

hoangnt2
Copy link
Contributor

What does this PR do?:

  • Fix bug nav bar links not working in production mode (cannot be clicked)
  • Adjust nav bar styling

heliocastro
heliocastro approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@heliocastro heliocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.
This dependency on Bootstrap sometimes causes headaches

@heliocastro
Copy link
Contributor

@hoangnt2 Missing sign ?

@hoangnt2
fix(Navbar): Fix bug cannot click navbar items in production mode
7365be8 
Signed-off-by: hoangnt2 <hoang2.nguyenthai@toshiba.co.jp>
@hoangnt2
Copy link
Contributor Author

hoangnt2 commented Feb 21, 2024 •
edited
Loading

@hoangnt2 Missing sign ?

@heliocastro Fixed it

@heliocastro heliocastro merged commit 1c53a68 into eclipse-sw360:main Feb 21, 2024
3 checks passed
@hoangnt2 hoangnt2 deleted the release/fix-navbar branch March 26, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heliocastro heliocastro heliocastro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoangnt2 @heliocastro