Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement edit license page #226

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Implement edit license page #226

merged 3 commits into from
Mar 4, 2024

Conversation

hoangnt2
Copy link
Contributor

@hoangnt2 hoangnt2 commented Mar 4, 2024

MicrosoftTeams-image

tuannn2 added 2 commits March 4, 2024 11:44
@tuannn2
feat(license): Add edit License detail page
cd6cdff 
Signed-off-by: tuannn2 <tuan2.nguyennhu@toshiba.co.jp>
@tuannn2
feat(license): Add edit License text page and edit linked Obligations…
f7d1519 
… page

Signed-off-by: tuannn2 <tuan2.nguyennhu@toshiba.co.jp>
@hoangnt2 hoangnt2 requested a review from heliocastro as a code owner March 4, 2024 06:39
heliocastro
heliocastro approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@heliocastro heliocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heliocastro heliocastro self-requested a review March 4, 2024 08:29
heliocastro
heliocastro requested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@heliocastro heliocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but still have unsigned commits

@hoangnt2 hoangnt2 force-pushed the release/edit_license_page branch from dab0562 to 2c163ca Compare March 4, 2024 08:32
@hoangnt2
Copy link
Contributor Author

hoangnt2 commented Mar 4, 2024

Good, but still have unsigned commits

@heliocastro solved it

@heliocastro heliocastro self-requested a review March 4, 2024 08:34
heliocastro
heliocastro approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@heliocastro heliocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heliocastro heliocastro merged commit 48addf9 into eclipse-sw360:main Mar 4, 2024
3 checks passed
@hoangnt2
fix(Lang): Add missing translation string
2c163ca 
Signed-off-by: hoangnt2 <hoang2.nguyenthai@toshiba.co.jp>
@hoangnt2 hoangnt2 deleted the release/edit_license_page branch December 12, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heliocastro heliocastro heliocastro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoangnt2 @heliocastro @tuannn2