Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[889] Remove New object/representation contextual menu entry for libraries #905

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

gdaniel
Copy link
Contributor

@gdaniel gdaniel commented Dec 16, 2024

Bug: #889

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@gdaniel
Copy link
Contributor Author

gdaniel commented Dec 16, 2024

To review later: this PR requires the integration of eclipse-sirius/sirius-web#4318 in Sirius Web.

CHANGELOG.adoc Outdated Show resolved Hide resolved
@gdaniel gdaniel force-pushed the gda/fix/removeCreateObjectFromContextualMenu branch from b09f543 to 923112a Compare December 18, 2024 15:11
@gdaniel gdaniel changed the title [889] Remove NewObject contextual menu entry for libraries [889] Remove New object/representation contextual menu entry for libraries Dec 18, 2024
Bug: #889
Signed-off-by: Gwendal Daniel <gwendal.daniel@obeosoft.com>
@AxelRICHARD AxelRICHARD force-pushed the gda/fix/removeCreateObjectFromContextualMenu branch from 923112a to fe3b1aa Compare December 19, 2024 16:36
@AxelRICHARD AxelRICHARD merged commit 86c744f into main Dec 19, 2024
4 checks passed
@AxelRICHARD AxelRICHARD deleted the gda/fix/removeCreateObjectFromContextualMenu branch December 19, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 'New Object' and 'New Representation' contextual menu entry for libraries
2 participants