Skip to content

Set loglevel specified in the properties file #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatthewKhouzam merged 1 commit into from
Apr 4, 2025
Merged

Set loglevel specified in the properties file #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/eclipse/tracecompass/traceeventlogger/AsyncFileHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ public Level getLevel() {
@Override
public boolean isLoggable(LogRecord record) {
// add feature switch here
return super.isLoggable(record) && (record instanceof TraceEventLogRecord);
return fFileHandler.isLoggable(record) && (record instanceof TraceEventLogRecord);
}

@Override
Expand Down
1 change: 1 addition & 0 deletions src/test/java/org/eclipse/tracecompass/traceeventlogger/AsyncFileHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public void testGoodConfigure() {
LogManager manager = LogManager.getLogManager();
manager.readConfiguration(fis);
Handler first = new AsyncFileHandler(File.createTempFile("test", ".json").getAbsolutePath()); //$NON-NLS-1$ //$NON-NLS-2$
assertEquals(Level.FINER, first.getLevel());
first.close();
} catch (FileNotFoundException e) {
fail(e.getMessage());
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/org/eclipse/tracecompass/traceeventlogger/res/goodlogging.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,5 @@ org.eclipse.tracecompass.traceeventlogger.AsyncFileHandler.flushRate = 100
org.eclipse.tracecompass.traceeventlogger.AsyncFileHandler.formatter = java.util.logging.SimpleFormatter
org.eclipse.tracecompass.traceeventlogger.AsyncFileHandler.filter = org.eclipse.tracecompass.traceeventlogger.FailFilter
org.eclipse.tracecompass.traceeventlogger.AsyncFileHandler.encoding = UTF-8
org.eclipse.tracecompass.traceeventlogger.AsyncFileHandler.errormanager = java.util.logging.ErrorManager
org.eclipse.tracecompass.traceeventlogger.AsyncFileHandler.errormanager = java.util.logging.ErrorManager
org.eclipse.tracecompass.traceeventlogger.AsyncFileHandler.level = FINER