Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(seeding): make seeder configureable #1174

Merged
merged 21 commits into from
Nov 28, 2024
Merged

feat(seeding): make seeder configureable #1174

merged 21 commits into from
Nov 28, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Nov 22, 2024 •
edited
Loading

Description

Add configuration to disable specific seeded values in the keycloak seeder

Why

To be able to seed only wanted values

Issue

Refs: #1172

Corresponding CD PR

eclipse-tractusx/portal-iam#234

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 requested review from ntruchsess and evegufy and removed request for ntruchsess November 22, 2024 13:11
@Phil91 Phil91 added this to the Release 2.3.0 (24.12) milestone Nov 22, 2024
@Phil91 Phil91 force-pushed the feature/1172-seeder branch from a427a48 to 26d3f48 Compare November 22, 2024 13:20
@Phil91 Phil91 changed the base branch from main to release/v2.3.0 November 22, 2024 13:20
@Phil91 Phil91 force-pushed the feature/1172-seeder branch from 26d3f48 to aae78ae Compare November 22, 2024 13:26
@Phil91 Phil91 mentioned this pull request Nov 22, 2024
Merged
6 tasks
evegufy
evegufy requested changes Nov 25, 2024
View reviewed changes
evegufy
evegufy requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 26ac07f, this configuration doesn't work anymore, for instance the cx-admin role isn't imported anymore, it works with the commit before 210bfb3

evegufy
evegufy approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested now everything successfully 👍

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 27, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
12 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

evegufy
evegufy approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested again, looks good 👍

@Phil91 Phil91 merged commit c38d4e9 into release/v2.3.0 Nov 28, 2024
11 checks passed
@Phil91 Phil91 deleted the feature/1172-seeder branch November 28, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

@evegufy evegufy evegufy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Portal
Status: USER READY
Milestone
Release 2.3.0 (24.12)
Development

Successfully merging this pull request may close these issues.
3 participants
@Phil91 @ntruchsess @evegufy