Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added custom toolbar element to ultimate table toolbar #414

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WaseemAbbasCofinityX
Copy link
Contributor

@WaseemAbbasCofinityX WaseemAbbasCofinityX commented Jan 20, 2025

Description

added custom element rendering in the ultimate table's toolbar to render the custom filter

Why

we need to render custom filter in one of the table to filter the usecases.

Issue

#418

Checklist

Please delete options that are not relevant.

  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
I the PR description you link to your company internal jira instance. Please correct that: all links in pull request and issues need to direkt to an open system to ensure an open source friendly development. So, I suggest you create an issue where you describe the bug in more details and link that in the PR description

@WaseemAbbasCofinityX
Copy link
Contributor Author

@evegufy Thanks for pointing that out! I've replaced the internal Jira link with a link to the public issue. Let me know if there are any other changes required.

@WaseemAbbasCofinityX
Copy link
Contributor Author

@evegufy if you have Time, can you please review this PR. I need this for my ticket in which I have to put a custom list filter in the header of a table for usecases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: IN PROGRESS
Development

Successfully merging this pull request may close these issues.

2 participants