Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: web errors formatting improvement #271

Merged
merged 6 commits into from
Oct 30, 2023
Merged

Conversation

tomaszbarwicki
Copy link
Contributor

@tomaszbarwicki tomaszbarwicki commented Oct 18, 2023

PR to improve quality check tool errors displayed as tooltips in the quality dashboard. By adding html data option within the tooltip it allows using html tags like line breaks. Implementation facilitates Web as well as CLI based formatted error messages.

Updates eclipse-tractusx/sig-infra#265

@tomaszbarwicki
Copy link
Contributor Author

PR depends on eclipse-tractusx/tractusx-quality-checks#56.
When new release of tractusx-quality-checks gets created, it has to be reflected in go modules. Afterwards build should be successful.

@tomaszbarwicki tomaszbarwicki marked this pull request as ready for review October 26, 2023 07:22
Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess IP validation is needed for new version

Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomaszbarwicki tomaszbarwicki merged commit 981093f into main Oct 30, 2023
@tomaszbarwicki tomaszbarwicki deleted the fix/error_formatting branch November 22, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants