Skip to content

Support comparison of UUri with URI strings#297

Merged
sophokles73 merged 1 commit intoeclipse-uprotocol:mainfrom
etas-contrib:support_comparison_of_uuri_with_str
Feb 12, 2026
Merged

Support comparison of UUri with URI strings#297
sophokles73 merged 1 commit intoeclipse-uprotocol:mainfrom
etas-contrib:support_comparison_of_uuri_with_str

Conversation

@sophokles73
Copy link
Contributor

Added PartialEq<&str> implementation for UUri to allow direct comparison between UUri instances and URI strings.

This enhancement simplifies code that needs to compare URIs without requiring explicit conversion to UUri.

Fixes #296

@sophokles73 sophokles73 added the enhancement New feature or request label Feb 12, 2026
Copy link
Contributor

@AnotherDaniel AnotherDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor question

@sophokles73 sophokles73 force-pushed the support_comparison_of_uuri_with_str branch 2 times, most recently from 79884bb to 759c5c8 Compare February 12, 2026 10:30
Added `PartialEq<&str>` implementation for `UUri` to allow direct
comparison between `UUri` instances and URI strings.

This enhancement simplifies code that needs to compare URIs without
requiring explicit conversion to `UUri`.

Fixes eclipse-uprotocol#296
@sophokles73 sophokles73 force-pushed the support_comparison_of_uuri_with_str branch from 759c5c8 to c5ccd89 Compare February 12, 2026 10:36
Copy link
Contributor

@AnotherDaniel AnotherDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophokles73 sophokles73 merged commit 90802d4 into eclipse-uprotocol:main Feb 12, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support comparing UUri with URI strings

2 participants