Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate usages of the Provider class #5104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yeikel
Copy link
Contributor

@yeikel yeikel commented Feb 7, 2024

The constructor we are using was deprecated in Java 9

 /**
     * Constructs a provider with the specified name, version number,
     * and information. Calling this constructor is equivalent to call the
     * {@link #Provider(String, String, String)} with {@code name}
     * name, {@code Double.toString(version)}, and {@code info}.
     *
     * @param name the provider name.
     *
     * @param version the provider version number.
     *
     * @param info a description of the provider and its services.
     *
     * @deprecated use {@link #Provider(String, String, String)} instead.
     */

The constructor we are using was deprecated in Java 9
@yeikel yeikel force-pushed the migrate/provider-class-usage branch from b97d312 to f7a523b Compare February 7, 2024 02:29
@zll600
Copy link

zll600 commented Apr 21, 2024

But jdk1.8 only has original version of api. ref: https://docs.oracle.com/javase/8/docs/api/java/security/Provider.html
And vertx is support JDK 1.8 or higher. ref: https://vertx.io/get-started/
Is it safe to do this?

@yeikel
Copy link
Contributor Author

yeikel commented Apr 22, 2024

But jdk1.8 only has original version of api. ref: https://docs.oracle.com/javase/8/docs/api/java/security/Provider.html
And vertx is support JDK 1.8 or higher. ref: https://vertx.io/get-started/
Is it safe to do this?

Vert.x 5 will target Java 11

@vietj vietj added this to the 5.0.0 milestone Apr 22, 2024
@vietj
Copy link
Member

vietj commented Apr 22, 2024

thanks , there are a few occurrences of this in other classes:

  • KeyManagerFactoryWrapper
  • TrustAllOptions
  • VertxTrustManagerFactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants