Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 5163 configurable socket keepalive interval #5183

Conversation

aksabg
Copy link

@aksabg aksabg commented Apr 10, 2024

@aksabg aksabg requested a review from vietj April 16, 2024 08:07
@vietj
Copy link
Member

vietj commented Sep 11, 2024

@aksabg can you signe the eclipse agreement ?

also can you avoid reformating code where it is not needed ?

@aksabg
Copy link
Author

aksabg commented Sep 17, 2024

@vietj Done

@vietj vietj force-pushed the feature-5163-configurable-socket-keepalive-interval branch from 7f30fe6 to 9d1d539 Compare September 19, 2024 20:12
@vietj vietj merged commit f9ab03b into eclipse-vertx:4.x Sep 20, 2024
7 checks passed
@vietj
Copy link
Member

vietj commented Sep 20, 2024

@aksabg thanks for contributing this

@vietj vietj added this to the 4.5.11 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants