Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace random access with round robin #687

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: replace random access with round robin #687

wants to merge 1 commit into from

Conversation

pmlopes
Copy link
Contributor

@pmlopes pmlopes commented Sep 10, 2024

Motivation:

JWS/JWT picks a random signer when multiple entries are known for the same algorithm. There are a few known problems here:

  1. we don't rely on a secure random
  2. random initialization interferes with build time initialization in Quarkus (not regular GraalVM)

With this behavior change we are more aligned with cloud vendors. We just round robin the keys.

@pmlopes
feat: replace random access with round robin
fb6d55c 
Signed-off-by: Paulo Lopes <pmlopes@users.noreply.github.com>
@pmlopes pmlopes marked this pull request as draft September 10, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pmlopes