Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testDate to identify invalid date and leap year #123

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

douglas-chanwh
Copy link
Contributor

@douglas-chanwh douglas-chanwh commented Dec 9, 2023

Motivation:
This pull request is to fix the issue "Improve validators to ensure more TCK test coverage #81"

Explain here the context, and why you're making that change, what is the problem you're trying to solve.
I made use of the DateTimeFormatter.ISO_DATE.parse(value); to verify if the input date string is valid or not.
It can detect input strings with invalid values such as 32 October, 29 Feb 2021.

Conformance:

You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

@douglas-chanwh
Copy link
Contributor Author

@vietj @InfoSec812 can you give me some comments on the PR? thanks

@pk-work
Copy link
Contributor

pk-work commented Dec 14, 2023

@lindangcdrom Thanks for your help! Your change looks good to me. Let's wait until tomorrow in case someone has feedback. Otherwise I will merge it.

@InfoSec812
Copy link

@lindangcdrom I like all of the test cases you are covering, so that makes me pretty confident that this will be great!

@pk-work pk-work merged commit e4c6cf0 into eclipse-vertx:master Dec 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants