Add check if WorkspaceFolders are supported or not #2801
Conversation
| initialize(initializer, callInitialized, false) | ||
| } | ||
|
|
||
| protected def InitializeResult initialize((InitializeParams)=>void initializer, boolean callInitialized, boolean useRootPath) { | ||
| val params = new InitializeParams => [ | ||
| processId = 1 | ||
| workspaceFolders = #[ | ||
| new WorkspaceFolder(root.toURI.normalize.toUriString, '') | ||
| ] | ||
| ] | ||
| initializer?.apply(params) |
There was a problem hiding this comment.
@szarnekow when I move the initializer after the useRootPath if, the tests fail with NullPointers. I will have to take a look into this.
There was a problem hiding this comment.
Did you figure why these failed when the order is swapped?
There was a problem hiding this comment.
I'm getting closer and closer. But I'm having some problems getting the tests to run locally. Is there any guidance/documentation on how to get them running locally.
There was a problem hiding this comment.
Which tests and what is the problem you are facing (maybe you have to select junit4 in the run dialog )
There was a problem hiding this comment.
The workspace was not setup correctly, but I don't know why. Everything was red and everything I tried didn't get it fixed. I now recreated the whole workspace with the eclipse installer and they are working again :)
There was a problem hiding this comment.
@szarnekow The reason for the NullPointerExceptions were some test classes where the WorkspaceFolder capability was not setup correctly.
org.eclipse.xtext.ide/src/org/eclipse/xtext/ide/server/LanguageServerImpl.java
Outdated
Show resolved
Hide resolved
org.eclipse.xtext.testing/xtend-gen/org/eclipse/xtext/testing/AbstractLanguageServerTest.java
Outdated
Show resolved
Hide resolved
|
what is the state here. @jnt0r can you please rebase and squash into 1 commit |
jnt0r
force-pushed
the
fork-main
branch
2 times, most recently
from
6fa8fcd to
707f31d
Compare
|
What's the state of this? |
Read through it and I like it. Can you please rebase your work and sign-off the commit? |
Signed-off-by: Jonathan Pollert <jona.pollert@gmail.com>
fixes #2699
reopens #2700