Remove redundant bundle requirements that are already fulfilled due to re-exports #2893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdietrich
approved these changes
Jan 8, 2024
Signed-off-by: Sebastian Zarnekow <sebastian.zarnekow@gmail.com>
It's re-exported from org.eclipse.xtext and thus the additional bundle requirement makes it harder for the OSGI resolver to find solutions (as counter-intuitive as it sounds) Signed-off-by: Sebastian Zarnekow <sebastian.zarnekow@gmail.com>
In fact it wasn't optional at all since it brought the xbase libraries into the class path which are used throughout the entire bundle code. Also xtext.util has already a mandatory dependency on xtend.lib so it does no harm to require it from xtext. Signed-off-by: Sebastian Zarnekow <sebastian.zarnekow@gmail.com>
It's re-exported from xtext.util and thereby transitively by xtext Signed-off-by: Sebastian Zarnekow <sebastian.zarnekow@gmail.com>
|
@szarnekow I'm fine with this PR, but please look at my comment about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.