Removed cyclic dependency to mwe2.launch #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @cdietrich |
cdietrich
reviewed
Jan 8, 2024
| @@ -13,6 +13,5 @@ exclude.. = **/GenerateXtend.mwe2 | |||
| src.includes = about.html | |||
| src.excludes = generator/,\ | |||
| generator-xtend-gen/ | |||
| additional.bundles = org.eclipse.emf.mwe2.launch,\ | |||
There was a problem hiding this comment.
did you try if run workflow works? for me it does not.
There was a problem hiding this comment.
Of course, my bad
We need to port the mwe2 file (back) to Java
There was a problem hiding this comment.
Yes, I just pushed that. I misread the error message. Multitasking is hard.
Signed-off-by: Sebastian Zarnekow <sebastian.zarnekow@gmail.com>
szarnekow
force-pushed
the
sz_issue2896
branch
from
97ec836 to
a4bfff8
Compare
cdietrich
approved these changes
Jan 8, 2024
LorenzoBettini
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.