[2836] adapt to changes in ltk.refactoring #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szarnekow
reviewed
Jan 10, 2024
| @@ -78,6 +80,11 @@ public void assertLogged(List<String> expectation) { | |||
| throw new ComparisonFailure("", expectedEventsDump, eventsDump); | |||
| } | |||
| } | |||
|
|
|||
| public void assertLogged(String expectation) { | |||
| String eventsDump = IterableExtensions.join(events, "\n"); | |||
There was a problem hiding this comment.
@szarnekow definitely yes :)
I've updated the other occurrences 2a47548
szarnekow
approved these changes
Jan 10, 2024
szarnekow
reviewed
Jan 10, 2024
| @@ -17,7 +19,6 @@ | |||
| import org.eclipse.core.runtime.NullProgressMonitor; | |||
| import org.eclipse.core.runtime.Platform; | |||
| import org.eclipse.ltk.core.refactoring.resource.RenameResourceDescriptor; | |||
| import org.eclipse.xtext.xbase.lib.IterableExtensions; | |||
szarnekow
reviewed
Jan 10, 2024
| + "Worked 21 (2124.0)\n" | ||
| + "Worked 21 (2145.0)\n" | ||
| + "Worked 21 (2166.0)\n" | ||
| + "Worked 84 (2250.0)\n" |
There was a problem hiding this comment.
Oh gosh this progresss reporting is awful.
41, 20, 84, 41, 41, 125 ...
Anyhow, not our fault.
There was a problem hiding this comment.
Indeed it is! :'(
At least, by directly comparing strings instead of creating lists of strings, from now on it should be easier to fix it
szarnekow
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2836
I created an easier way to specify the expectation as a string.