Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test script #169
test: add test script #169
Changes from 5 commits
47eba8f
c91c36c
980f98f
0a16a71
a2f8716
78a49b6
d44041f
b3947b1
3b290d8
e046371
067860c
29c278d
af3a05a
dfd04fd
9d27dd4
cba4d03
60c6201
302ddd9
c8f7dc5
c30b29d
1dfc64b
36199f9
921cebf
0390228
ebddd4e
3498e99
664f26c
c92bee4
ca6ce2b
6b86541
72bbeee
10cc755
5278a3b
a74117f
4582202
4e086ff
5767b6c
e68346e
d05d5fd
772c5d5
bb10085
c3ff32e
d8ee7b0
7b655af
300ac39
19bab28
4c98504
c22d71a
e3d4fd9
0d73741
c68eb94
f990ab5
c90d6d8
6f25443
49a3b21
67b1366
2c9d31c
5b16f1b
b44f2b5
83db30d
d92f145
15dcbe1
b2e9608
cb060ea
6a5732e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to put the correct path in the default options. If users run the "help" option and see
"/.config/…"
they can assume that something is wrong.There is the function:
os.path.expanduser()
.What I suggest you do: provide a default option with
~
in the path & callexpanduser
in all cases (be it the default option or provided by the user).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that you are not just looking for
zenohd
processes, I would rather write:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't this be simplified like so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these lines, they are too specific and will quickly return false negatives.
They are referred to as "magic numbers" and are considered bad practice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering the previous change I asked you to do, these lines need to be removed as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the test to be more reliable, you need to:
curl