fix: resolve the memory leak in the string deserialization (#363)

YuanYuYuan · DenisBiryukov91 · web-flow · commit 9ca8cc170e68 · 2025-01-08T17:55:15.000+08:00
* fix: resolve the memory leak in the string deserialization

* chore: apply the suggestion

Co-authored-by: DenisBiryukov91 &lt;155981813+DenisBiryukov91@users.noreply.github.com&gt;

---------

Co-authored-by: DenisBiryukov91 &lt;155981813+DenisBiryukov91@users.noreply.github.com&gt;
diff --git a/include/zenoh/api/ext/serialization.hxx b/include/zenoh/api/ext/serialization.hxx
@@ -278,6 +278,7 @@ inline bool __zenoh_deserialize_with_deserializer(zenoh::ext::Deserializer& dese
     __ZENOH_RESULT_CHECK(::ze_deserializer_deserialize_string(interop::as_copyable_c_ptr(deserializer), &s), err,
                          "Deserialization failure");
     value = std::string(::z_string_data(::z_loan(s)), ::z_string_len(::z_loan(s)));
+    ::z_drop(::z_move(s));
     return err == nullptr || *err == Z_OK;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -278,6 +278,7 @@ inline bool __zenoh_deserialize_with_deserializer(zenoh::ext::Deserializer& dese`
`278`	`278`	`__ZENOH_RESULT_CHECK(::ze_deserializer_deserialize_string(interop::as_copyable_c_ptr(deserializer), &s), err,`
`279`	`279`	`"Deserialization failure");`
`280`	`280`	`value = std::string(::z_string_data(::z_loan(s)), ::z_string_len(::z_loan(s)));`
	`281`	`+ ::z_drop(::z_move(s));`
`281`	`282`	`return err == nullptr \|\| *err == Z_OK;`
`282`	`283`	`}`
`283`	`284`