RISCV build databroker-cli - Adressing minor review comments

Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
eclipse · Nov 9, 2023 · 28cdad3 · 28cdad3
1 parent ee1d8f6
commit 28cdad3
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 4 deletions.
diff --git a/kuksa_databroker/Dockerfile b/kuksa_databroker/Dockerfile
@@ -31,8 +31,10 @@ COPY ./target/aarch64-unknown-linux-musl/release/databroker /app/databroker
 
 
 # RISCV is a glibc build. Rust toolchain not supported for MUSL
-# Distroless has not RISCV support yet, using debian for now
-#FROM gcr.io/distroless/base-debian12:debug as target-riscv64
+# Normally we prefer "distroless" base images, i.e.:
+# FROM gcr.io/distroless/base-debian12:debug as target-riscv64
+# However, distorless has no RISCV support yet,
+# (Nov 2023). Using debian unstable for now
 FROM riscv64/debian:sid-slim as target-riscv64
 
 ENV BUILDTARGET="riscv64gc-unknown-linux-gnu"

diff --git a/kuksa_databroker/Dockerfile-cli b/kuksa_databroker/Dockerfile-cli
@@ -28,8 +28,10 @@ COPY ./target/aarch64-unknown-linux-musl/release/databroker-cli /app/databroker-
 
 
 # RISCV is a glibc build. Rust toolchain not supported for MUSL
-# Distroless has not RISCV support yet, using debian for now
-#FROM gcr.io/distroless/base-debian12:debug as target-riscv64
+# Normally we prefer "distroless" base images, i.e.:
+# FROM gcr.io/distroless/base-debian12:debug as target-riscv64
+# However, distorless has no RISCV support yet,
+# (Nov 2023). Using debian unstable for now
 FROM riscv64/debian:sid-slim as target-riscv64
 ENV BUILDTARGET="riscv64gc-unknown-linux-gnu"
 COPY ./target/riscv64gc-unknown-linux-gnu/release/databroker-cli /app/databroker-cli

diff --git a/kuksa_databroker/build-all-targets-cli.sh b/kuksa_databroker/build-all-targets-cli.sh
@@ -1,10 +1,15 @@
 #!/bin/bash
 #
+# Copyright (c) 2023 Contributors to the Eclipse Foundation
+#
 # Building all currently supported targets for databroker-cli.
 # Uses cross for cross-compiling. Needs to be executed
 # before docker build, as docker collects the artifacts
 # created by this script
 # this needs the have cross, cargo-license and createbom dependencies installed
+#
+# SPDX-License-Identifier: Apache-2.0
+
 
 # exit on error, to not waste any time
 set -e

diff --git a/kuksa_databroker/build-all-targets.sh b/kuksa_databroker/build-all-targets.sh
@@ -1,10 +1,14 @@
 #!/bin/bash
 #
+# Copyright (c) 2023 Contributors to the Eclipse Foundation
+#
 # Building all currently supported targets.
 # Uses cross for cross-compiling. Needs to be executed
 # before docker build, as docker collects the artifacts
 # created by this script
 # this needs the have cross, cargo-license and createbom dependencies installed
+#
+# SPDX-License-Identifier: Apache-2.0
 
 # exit on error, to not waste any time
 set -e