-
Notifications
You must be signed in to change notification settings - Fork 42
Test turning all grad checkpointings off #1168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
javak87
wants to merge
22
commits into
ecmwf:develop
Choose a base branch
from
javak87:javad/dev/cond_checkpoint_all-1141
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Test turning all grad checkpointings off #1168
javak87
wants to merge
22
commits into
ecmwf:develop
from
javak87:javad/dev/cond_checkpoint_all-1141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into javad/dev/cond_checkpoint_embed_transformer
…/cond_checkpoint_all-1141
…javad/dev/cond_checkpoint_all-1141
…javad/dev/cond_checkpoint_all-1141
…cond_checkpoint_all-1141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a merge branch related to the following PRs:
#1151
#1152
#1153
#1155
#1156
Issue Number
Refs #1141
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60Comparing the baseline and current PR performance
When
pred_gradient_checkpoint_modeis set to false, the performance and GPU memory peak are as follows:default_config.yml:
../WeatherGenerator-private/hpc/launch-slurm.py --time 60mixed.yml:
../WeatherGenerator-private/hpc/launch-slurm.py --time 60 --config ./config/mixed.yml