Skip to content

Conversation

@simone99n
Copy link
Contributor

@simone99n simone99n commented Nov 7, 2025

Description

  • Implementation of E-Obs Datareader
  • Tested on Juwels-Booster (run_id: sn1034g and sn1034h)
  • Needs to be moved to
    packages/readers_extra/src/weathergen/readers_extra (+ small changes) for compatibility with issue Sub-package for experimental data readers and code #1206
  • This PR is complementary to the Merge request !83 on the private repository

Issue Number

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

from weathergen.utils.train_logger import Stage

type AnyDataReader = DataReaderBase | DataReaderAnemoi | DataReaderObs
type AnyDataReader = DataReaderBase | DataReaderAnemoi | DataReaderObs | DataReaderEObs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not need this change

@tjhunter
Copy link
Collaborator

@simone99n I merge the data readers extra PR. Can you move your reader there? then it can be approved when ready on your side.

@simone99n simone99n closed this Nov 10, 2025
@simone99n simone99n force-pushed the simone99n/dev/1034_eobs_datareader branch from 0caf062 to d38e01c Compare November 10, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

E-OBS Data Reader implementation

2 participants