Skip to content

Conversation

grassesi
Copy link
Contributor

@grassesi grassesi commented Sep 15, 2025

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Issue Number

Closes #898

Code Compatibility

  • I have performed a self-review of my code

Code Performance and Testing

  • I ran the uv run train and (if necessary) uv run evaluate on a least one GPU node and it works
  • If the new feature introduces modifications at the config level, I have made sure to have notified the other software developers through Mattermost and updated the paths in the $WEATHER_GENERATOR_PRIVATE directory

Dependencies

  • I have ensured that the code is still pip-installable after the changes and runs
  • I have tested that new dependencies themselves are pip-installable.
  • I have not introduced new dependencies in the inference portion of the pipeline

Documentation

  • My code follows the style guidelines of this project
  • I have updated the documentation and docstrings to reflect the changes
  • I have added comments to my code, particularly in hard-to-understand areas

Additional Notes

Copy link
Collaborator

@tjhunter tjhunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grassesi first feedback

@grassesi grassesi force-pushed the sgrasse/develop/issue_898-checkpoint_freq_conf branch from f6fce16 to e541e2b Compare September 17, 2025 12:03
@grassesi grassesi force-pushed the sgrasse/develop/issue_898-checkpoint_freq_conf branch from 31946ea to 7272b96 Compare September 18, 2025 14:33
@grassesi grassesi marked this pull request as ready for review September 18, 2025 14:38
@grassesi grassesi requested a review from tjhunter September 18, 2025 14:38
@grassesi grassesi force-pushed the sgrasse/develop/issue_898-checkpoint_freq_conf branch 2 times, most recently from 7016bc5 to 6d035f5 Compare September 23, 2025 08:28
"print_summary": True,
"evaluation": {"metrics": ["rmse", "l1", "mse"]},
"global_plotting_options": {
"image_format": "png",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you. clearly we are not running the test suite like we should?

@tjhunter
Copy link
Collaborator

@grassesi : the faliing job should go away once you update against dev.

@grassesi grassesi force-pushed the sgrasse/develop/issue_898-checkpoint_freq_conf branch from 6d035f5 to 638b6ce Compare October 6, 2025 13:00
@grassesi grassesi force-pushed the sgrasse/develop/issue_898-checkpoint_freq_conf branch from bec9688 to 0ab56a6 Compare October 14, 2025 10:15
@grassesi grassesi merged commit 43eb49b into ecmwf:develop Oct 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Rework configuration for frequency of training artifacts

2 participants