Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/mlflow sync tag #83

Merged
merged 45 commits into from
Oct 21, 2024
Merged

Fix/mlflow sync tag #83

merged 45 commits into from
Oct 21, 2024
+312 −132

Conversation

anaprietonem
Copy link
Contributor

This PR includes:

  • Fix in mlflow-sync for when we want to sync a new-experiment that doesn't yet exist on the remote server
  • Bring a new tag to distinguish between those runs that are synced from offline to online and those are synced 'online' to 'online' (ie between two different remove servers)

gmertes and others added 22 commits September 9, 2024 13:16
@gmertes
feat: authentication support for mlflow sync
d6fa830
@gmertes
chore: formatting
4606e76
@gmertes
chore: changelog
620f3a0
@JesperDramsch
Merge remote-tracking branch 'origin/develop' into feat/mlflow-sync-auth
2dd693b
@gmertes
chore: changelog add link
debf2ab
@gmertes
Merge branch 'develop' into feat/mlflow-sync-auth
a70e22c
@gmertes
fix: mlflow auth use web seed token
60d0dcc
@gmertes
feat: make target env var an optional argument
e5ab3ec
@gmertes
chore: docstrings
93ce7a8
@gmertes
fix: tests
391a494
@gmertes
chore: add comment
2f7f1c2
@gmertes
chore: changelog
498c6de
@gmertes
fix: sync authentication flag
b54c475
@gmertes
refactor: move health_check to submodule top level
4693972
@gmertes
feat: add health check
6fed2e7
@gmertes
chore: update error msg
34a3f37
@gmertes
refactor: mlflow utils
0116027
@gmertes
chore: docstring
6b97a56
@anaprietonem
Merge branch 'fix/mlflow-auth-api' into fix/mlflow_sync_tag
9b3088c
@anaprietonem
tag and catch for new experiments
81ee192
@anaprietonem
Merge branch 'develop' into fix/mlflow_sync_tag
caae529
@anaprietonem
update changelog
a69872e
@anaprietonem anaprietonem marked this pull request as draft October 14, 2024 11:05
@anaprietonem anaprietonem changed the title [WIP] Fix/mlflow sync tag Fix/mlflow sync tag Oct 14, 2024
@gmertes gmertes mentioned this pull request Oct 15, 2024
Merged
@anaprietonem anaprietonem marked this pull request as ready for review October 18, 2024 08:05
gmertes
gmertes requested changes Oct 18, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/anemoi/training/diagnostics/mlflow/logger.py Outdated Show resolved Hide resolved
src/anemoi/training/diagnostics/mlflow/logger.py Outdated Show resolved Hide resolved
src/anemoi/training/train/train.py Outdated Show resolved Hide resolved
src/anemoi/training/train/train.py Outdated Show resolved Hide resolved
src/anemoi/training/train/train.py Outdated Show resolved Hide resolved
src/anemoi/training/utils/mlflow_sync.py Outdated Show resolved Hide resolved
@gmertes
Copy link
Member

gmertes commented Oct 18, 2024

Use squash when we merge this one

otherwise it will merge in a lot of unnecessary commits that were squashed in other PRs

@gmertes gmertes merged commit e592f3f into develop Oct 21, 2024
99 of 101 checks passed
@gmertes gmertes deleted the fix/mlflow_sync_tag branch October 21, 2024 14:33
@gmertes gmertes mentioned this pull request Oct 22, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmertes gmertes gmertes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anaprietonem @gmertes @JesperDramsch