remove decorator that is not compatible with all CDS datasets #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #605 +/- ##
========================================
Coverage 90.28% 90.28%
========================================
Files 153 153
Lines 11565 11565
Branches 546 546
========================================
Hits 10442 10442
Misses 953 953
Partials 170 170 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decorator breaks requests for some datasets where the daterange is required as a daterange in the cds/ads request (I'm just finding a nice example).
Eitherway, this modifying of requests has the potential to lead to misunderstandings/incompatibilities in the future. We can have the exception of the the area as here it is a case of mapping the earhtkit style dictionary to the CDS style list for an area definition.