Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

earthkit.regrid.utils.Stream write functionality (for most data types) #52

Merged
merged 13 commits into from
Jan 20, 2025

Conversation

pmaciel
Copy link
Member

@pmaciel pmaciel commented Jan 14, 2025

Double was tricky

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 92.08%. Comparing base (c38affa) to head (cd54bc4).

Files with missing lines Patch % Lines
tests/test_make_matrix.py 56.25% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #52      +/-   ##
===========================================
- Coverage    93.09%   92.08%   -1.02%     
===========================================
  Files            9       10       +1     
  Lines          565      581      +16     
  Branches        15       16       +1     
===========================================
+ Hits           526      535       +9     
- Misses          32       38       +6     
- Partials         7        8       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmaciel pmaciel force-pushed the feature/stream-write branch from 199336e to 4eaf159 Compare January 17, 2025 21:34
@FussyDuck
Copy link

FussyDuck commented Jan 18, 2025

CLA assistant check
All committers have signed the CLA.

if output is None:
return mir_cached_matrix_to_array(matrices[0])

if ext == ".npz":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ext is not defined! This code should be checked.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a moving target, sorry about that. Fixed

@sandorkertesz sandorkertesz merged commit e7ef7db into develop Jan 20, 2025
106 checks passed
@sandorkertesz sandorkertesz deleted the feature/stream-write branch January 20, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants