-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for two FESOM grids #171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do these new ones not follow the convention of the others? i.e. they do not include the ORCA substring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not ORCA grids. They also do not follow the ARAKAWA staggering so we don't have a difference between U and V, etc. So Seb suggested we use different subtypes also.
If we can restrict what subtypes each type can take, it would be that NG5 and CORE2 would only be able to take these two subtypes (E, N).
Added a JIRA for this: |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #171 +/- ##
========================================
Coverage 80.80% 80.80%
========================================
Files 527 527
Lines 58490 58490
========================================
Hits 47263 47263
Misses 11227 11227 ☔ View full report in Codecov by Sentry. |
Please rename the "E" to "C", which is not confusing: |
It is in the long-term plan at ECMWF to support interpolation and output on FESOM2 grids. For the upcoming climate-DT runs, it will suffice to support two grids: NG5 and CORE2.
For more information, please see FESOM geometry and FESOM uids.