Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for two FESOM grids #171

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Conversation

dsarmany
Copy link

It is in the long-term plan at ECMWF to support interpolation and output on FESOM2 grids. For the upcoming climate-DT runs, it will suffice to support two grids: NG5 and CORE2.

For more information, please see FESOM geometry and FESOM uids.

@dsarmany dsarmany requested a review from shahramn October 18, 2023 17:21
@shahramn shahramn self-assigned this Oct 18, 2023
@shahramn shahramn added the approved-for-ci Approved to run CI on ECMWF machines label Oct 18, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these new ones not follow the convention of the others? i.e. they do not include the ORCA substring

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not ORCA grids. They also do not follow the ARAKAWA staggering so we don't have a difference between U and V, etc. So Seb suggested we use different subtypes also.

If we can restrict what subtypes each type can take, it would be that NG5 and CORE2 would only be able to take these two subtypes (E, N).

@shahramn
Copy link
Collaborator

Added a JIRA for this:
https://jira.ecmwf.int/browse/ECC-1707

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7e82370) 80.80% compared to head (21e28ab) 80.80%.
Report is 46 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #171   +/-   ##
========================================
  Coverage    80.80%   80.80%           
========================================
  Files          527      527           
  Lines        58490    58490           
========================================
  Hits         47263    47263           
  Misses       11227    11227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahramn shahramn changed the base branch from develop to hotfix/2.32.1 October 19, 2023 11:47
@shahramn shahramn merged commit 55f2b26 into hotfix/2.32.1 Oct 19, 2023
103 of 105 checks passed
@shahramn shahramn deleted the feature/fesom-grid-types branch October 19, 2023 11:47
@wdeconinck
Copy link
Member

Please rename the "E" to "C", which is not confusing:
C for Cells, or Centres or Centroids is not confusing.
E could stand for Edges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-for-ci Approved to run CI on ECMWF machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants