Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECC-1832: GRIB2: Destination Earth On-Demand ExtremesDT metadata support #267

Merged
merged 13 commits into from
Nov 14, 2024
Merged

ECC-1832: GRIB2: Destination Earth On-Demand ExtremesDT metadata support #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fd8f691
ECC-1832: First attempt.
mjg41 May 17, 2024
34f6312
Merge remote-tracking branch 'origin/develop' into feature/ECC-1832-O…
mjg41 Aug 2, 2024
2979f44
ECC-1832: Moved templates into templates directory
mjg41 Aug 2, 2024
1e9ce15
Merge remote-tracking branch 'origin/develop' into feature/ECC-1832-O…
mjg41 Oct 30, 2024
f5440f8
ECC-1832: Trying with a transient key centroid
mjg41 Oct 30, 2024
1621140
ECC-1832: Removed extra newline after merge.
mjg41 Oct 30, 2024
9a2af58
ECC-1832: Use ascii string.
mjg41 Oct 30, 2024
3a6b657
ECC-1832: Updated test to look at new key.
mjg41 Oct 31, 2024
d296ce6
Merge remote-tracking branch 'origin/develop' into feature/ECC-1832-O…
mjg41 Oct 31, 2024
0f8a95e
Merge remote-tracking branch 'origin/develop' into feature/ECC-1832-O…
mjg41 Nov 13, 2024
8b79df4
ECC-1832: Use key name "georef" and but default as legitimate geohash
mjg41 Nov 13, 2024
89940a5
ECC-1832: Better to use an 8-digit value to test
mjg41 Nov 13, 2024
4ac238f
ECC-1832: Add check of MARS namespace key to test
mjg41 Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions definitions/grib2/local.destine.on-demand-extremes-dt.def
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# DestinE MARS On-Demand ExtremesDT keywords

# Default is lat,long 0.0,0.0 to 8 chars precision from geolib

ascii[8] georef = "s0000000" : dump ;
alias mars.georef = georef;
13 changes: 13 additions & 0 deletions tests/grib_destine_mars_keys.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,5 +97,18 @@ ${tools_dir}/grib_ls -jm $temp_grib_a
${tools_dir}/grib_set -s productionStatusOfProcessedData=12 $sample_grib2 $temp_grib_a
${tools_dir}/grib_compare -b productionStatusOfProcessedData $sample_grib2 $temp_grib_a

# ECC-1832 On-Demand DT metadata
# Check setting dataset to on-demand-extremes-dt (4). Check keys are present and equal defaults
${tools_dir}/grib_set -s dataset=4 $destine_sample $temp_grib_a

grib_check_key_exists $temp_grib_a dataset,georef
grib_check_key_equals $temp_grib_a "dataset,dataset:s,georef,mars.georef" "4 on-demand-extremes-dt s0000000 s0000000"

# Check an example where a few additional things are set in on-demand-extremes-dt

${tools_dir}/grib_set -s dataset=4,georef=gcpkd2eu $destine_sample $temp_grib_a

grib_check_key_equals $temp_grib_a "georef" "gcpkd2eu"

# Clean up
rm -f $temp_grib_a $temp_grib_b $destine_sample
Loading