Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECC-1928: GRIB2 DestinE: Solution for switch of paramId for 100m and 200m wind components on height levels #269

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

mjg41
Copy link
Collaborator

@mjg41 mjg41 commented Nov 15, 2024

https://jira.ecmwf.int/browse/ECC-1928

This fix implements the 100m and 200m wind transition of paramId (e.g. 228246/228247) to the generic u/v components (131/132) for DestinE. More specifically:

  • class=d1,dataset=climate-dt,generation=1: Preserve the old behaviour with paramId 228246/228247.
  • class=d1,dataset=climate-dt,generation>1: New behaviour using 131/132
  • class=d1,dataset=extremes-dt: New behaviour using 131/132
  • class=d1,dataset=on-demand-extremes-dt: New behaviour using 131/132

It also preserves the destineOrigin and gridSpecification concepts for ClimateDT generation 1 data.

@mjg41 mjg41 requested a review from shahramn November 15, 2024 09:13
@mjg41 mjg41 self-assigned this Nov 15, 2024
@shahramn shahramn self-assigned this Nov 15, 2024
@shahramn shahramn added the approved-for-ci Approved to run CI on ECMWF machines label Nov 15, 2024
@shahramn shahramn changed the title feature/ecc-1928 100m & 200m winds ECC-1928: GRIB2 DestinE: Solution for switch of paramId for 100m and 200m wind components on height levels Nov 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.74%. Comparing base (40b6fcb) to head (e99525c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #269   +/-   ##
========================================
  Coverage    87.74%   87.74%           
========================================
  Files          808      808           
  Lines        62085    62085           
  Branches     11021    11021           
========================================
  Hits         54479    54479           
  Misses        7606     7606           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahramn shahramn merged commit 4d738fb into develop Nov 15, 2024
352 of 354 checks passed
@shahramn shahramn deleted the feature/ECC-1928-winds branch November 15, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-for-ci Approved to run CI on ECMWF machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants