Fix interaction between overlay and auxiliary purge/wipe

ecmwf · Aug 12, 2024 · f70eb76 · f70eb76
1 parent cf021ef
commit f70eb76
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/src/fdb5/toc/TocPurgeVisitor.cc b/src/fdb5/toc/TocPurgeVisitor.cc
@@ -43,9 +43,16 @@ bool TocPurgeVisitor::visitDatabase(const Catalogue& catalogue, const Store& sto
         indexUsage_[path] += 0;
     }
 
-    for (const auto& path : data) {
-        allDataFiles_.insert(path.path());
-        dataUsage_[path.path()] += 0;
+    for (const auto& uri : data) {
+        if (!store.uriBelongs(uri)) {
+            Log::error() << "Catalogue is pointing to data files that do not belong to the store." << std::endl;
+            Log::error() << "Configured Store URI: " << store.uri().asString() << std::endl;
+            Log::error() << "Pointed Store unit URI: " << uri.asString() << std::endl;
+            Log::error() << "This may occur when purging an overlayed FDB, which is not supported." << std::endl;
+            NOTIMP;
+        }
+        allDataFiles_.insert(uri.path());
+        dataUsage_[uri.path()] += 0;
     }
 
     return true;

diff --git a/src/fdb5/toc/TocWipeVisitor.cc b/src/fdb5/toc/TocWipeVisitor.cc
@@ -164,7 +164,6 @@ bool TocWipeVisitor::visitIndex(const Index& index) {
 
     std::vector<eckit::URI> indexDataPaths(index.dataURIs());
     for (const eckit::URI& uri : store_.asCollocatedDataURIs(indexDataPaths)) {
-        auto auxPaths = getAuxiliaryPaths(uri);
         if (include) {
             if (!store_.uriBelongs(uri)) {
                 Log::error() << "Index to be deleted has pointers to fields that don't belong to the configured store." << std::endl;
@@ -174,10 +173,14 @@ bool TocWipeVisitor::visitIndex(const Index& index) {
                 NOTIMP;
             }
             dataPaths_.insert(eckit::PathName(uri.path()));
+            auto auxPaths = getAuxiliaryPaths(uri);
             auxiliaryDataPaths_.insert(auxPaths.begin(), auxPaths.end());
         } else {
             safePaths_.insert(eckit::PathName(uri.path()));
-            safePaths_.insert(auxPaths.begin(), auxPaths.end());
+            if (store_.uriBelongs(uri)) {
+                auto auxPaths = getAuxiliaryPaths(uri);
+                safePaths_.insert(auxPaths.begin(), auxPaths.end());
+            }
         }
     }