Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remoteFDB - constness improvements #67

Closed
wants to merge 4 commits into from

Conversation

mcakircali
Copy link
Contributor

@mcakircali mcakircali commented Jan 14, 2025

closed see #68

@mcakircali mcakircali requested a review from danovaro January 14, 2025 15:59
src/fdb5/remote/Connection.cc Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 86 lines in your changes missing coverage. Please review.

Project coverage is 50.31%. Comparing base (1336a19) to head (1c573a6).

Files with missing lines Patch % Lines
src/fdb5/remote/Connection.cc 0.00% 20 Missing ⚠️
src/fdb5/remote/server/ServerConnection.cc 0.00% 16 Missing ⚠️
src/fdb5/remote/client/ClientConnection.cc 0.00% 15 Missing ⚠️
src/fdb5/remote/client/Client.cc 0.00% 10 Missing ⚠️
src/fdb5/remote/Connection.h 0.00% 4 Missing ⚠️
src/fdb5/remote/client/RemoteCatalogue.cc 0.00% 4 Missing ⚠️
src/fdb5/remote/client/RemoteCatalogue.h 0.00% 4 Missing ⚠️
src/fdb5/remote/client/RemoteStore.cc 0.00% 3 Missing ⚠️
src/fdb5/remote/Messages.h 0.00% 2 Missing ⚠️
src/fdb5/remote/client/ClientConnection.h 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@              Coverage Diff               @@
##           remoteFDB      #67       +/-   ##
==============================================
- Coverage      61.21%   50.31%   -10.90%     
==============================================
  Files            265      260        -5     
  Lines          14935    14273      -662     
  Branches        1474     1428       -46     
==============================================
- Hits            9142     7182     -1960     
- Misses          5793     7091     +1298     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcakircali mcakircali force-pushed the feature/remoteFDB-const-connection branch from 4b2a1f0 to 1c573a6 Compare January 16, 2025 16:48
@mcakircali mcakircali closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants