Skip to content

Commit

Permalink
MIR-592 Wind vector components at the poles, fixed displacement
Browse files Browse the repository at this point in the history
  • Loading branch information
pmaciel committed Dec 10, 2024
1 parent 6b94df4 commit 0667c57
Show file tree
Hide file tree
Showing 9 changed files with 25 additions and 5 deletions.
5 changes: 5 additions & 0 deletions src/mir/method/fe/FiniteElement.cc
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,11 @@ void FiniteElement::print(std::ostream& out) const {
}


int FiniteElement::version() const {
return 1;
}


bool FiniteElement::sameAs(const Method& other) const {
const auto* o = dynamic_cast<const FiniteElement*>(&other);
return (o != nullptr) && meshGeneratorParams_.sameAs(o->meshGeneratorParams_) &&
Expand Down
2 changes: 2 additions & 0 deletions src/mir/method/fe/FiniteElement.h
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ class FiniteElement : public MethodWeighted {
void json(eckit::JSON&) const override;
void print(std::ostream&) const override;

int version() const override;

// -- Overridden methods
// None

Expand Down
2 changes: 1 addition & 1 deletion src/mir/method/gridbox/GridBoxAverage.cc
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ const char* GridBoxAverage::name() const {


int GridBoxAverage::version() const {
return 4;
return 5;
}


Expand Down
2 changes: 1 addition & 1 deletion src/mir/method/gridbox/GridBoxStatistics.cc
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ const char* GridBoxStatistics::name() const {


int GridBoxStatistics::version() const {
return 4;
return 5;
}


Expand Down
5 changes: 5 additions & 0 deletions src/mir/method/knn/KNearestNeighbours.cc
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,11 @@ void KNearestNeighbours::print(std::ostream& out) const {
}


int KNearestNeighbours::version() const {
return 1;
}


WeightMatrix::Check KNearestNeighbours::validateMatrixWeights() const {
return distanceWeighting().validateMatrixWeights();
}
Expand Down
1 change: 1 addition & 0 deletions src/mir/method/knn/KNearestNeighbours.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ class KNearestNeighbours : public MethodWeighted {
void print(std::ostream&) const override;

const char* name() const override = 0;
int version() const override;

virtual const pick::Pick& pick() const = 0;
virtual const distance::DistanceWeighting& distanceWeighting() const = 0;
Expand Down
5 changes: 5 additions & 0 deletions src/mir/method/voronoi/VoronoiMethod.cc
Original file line number Diff line number Diff line change
Expand Up @@ -178,4 +178,9 @@ const char* VoronoiMethod::name() const {
}


int VoronoiMethod::version() const {
return 1;
}


} // namespace mir::method::voronoi
1 change: 1 addition & 0 deletions src/mir/method/voronoi/VoronoiMethod.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class VoronoiMethod : public MethodWeighted {
void print(std::ostream&) const override;
WeightMatrix::Check validateMatrixWeights() const override;
const char* name() const override;
int version() const override;

knn::pick::NClosestOrNearest pick_;
};
Expand Down
7 changes: 4 additions & 3 deletions src/mir/util/Point2ToPoint3.cc
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,10 @@ Point2ToPoint3::Point3Displaced::Point3Displaced(double poleDisplacement) : eps_


Point3 Point2ToPoint3::Point3Displaced::make_point3(const Point2& p2) const {
const Point2 p2d{p2[0], Latitude::NORTH_POLE == p2[1] ? p2[1] - eps_
: Latitude::SOUTH_POLE == p2[1] ? p2[1] + eps_
: p2[1]};
const Point2 p2d{Latitude::NORTH_POLE <= p2[0] + eps_ ? p2[0] - eps_
: Latitude::SOUTH_POLE >= p2[0] - eps_ ? p2[0] + eps_
: p2[0],
p2[1]};
return repres::Iterator::point_3D(p2d);
}

Expand Down

0 comments on commit 0667c57

Please sign in to comment.