Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/metric speed #60

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Hotfix/metric speed #60

wants to merge 4 commits into from

Conversation

sametd
Copy link
Member

@sametd sametd commented Jan 15, 2025

This PR:

  • Optimises get_metrics function for mongodb backend using exclusion of unnecessary records
  • Raises NotImplementedError for dynamodb for the optimisation
  • Implements the optimisation in the telemetry

peshence
peshence approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@peshence peshence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of small comments but they're just opinions, up to you if you want to change

polytope_server/common/metric_store/mongodb_metric_store.py Show resolved Hide resolved
polytope_server/telemetry/helpers.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peshence peshence peshence approved these changes

@jameshawkes jameshawkes Awaiting requested review from jameshawkes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sametd @peshence