Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/non decorator transformations #107

Merged
merged 7 commits into from
Mar 4, 2024

Conversation

mathleur
Copy link
Member

No description provided.

@mathleur
Copy link
Member Author

Remove transformation decorators and recursively get the transformations to apply on the axes instead

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

Attention: Patch coverage is 93.77593% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 89.35%. Comparing base (41011ee) to head (79d818d).

❗ Current head 79d818d differs from pull request most recent head f8247a1. Consider uploading reports for the commit f8247a1 to get more accurate results

Files Patch % Lines
...ansformations/datacube_reverse/datacube_reverse.py 82.35% 6 Missing ⚠️
polytope/datacube/datacube_axis.py 87.50% 5 Missing ⚠️
...tacube/transformations/datacube_transformations.py 87.50% 2 Missing ⚠️
polytope/datacube/backends/fdb.py 0.00% 1 Missing ⚠️
...transformations/datacube_cyclic/datacube_cyclic.py 98.68% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #107      +/-   ##
===========================================
+ Coverage    87.21%   89.35%   +2.13%     
===========================================
  Files           96       78      -18     
  Lines         7175     6898     -277     
===========================================
- Hits          6258     6164      -94     
+ Misses         917      734     -183     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jameshawkes jameshawkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Add init.py's then approved.

Copy link
Member Author

@mathleur mathleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added init.py

@jameshawkes jameshawkes self-requested a review March 4, 2024 11:18
@jameshawkes jameshawkes merged commit 522de07 into develop Mar 4, 2024
6 checks passed
@jameshawkes jameshawkes deleted the feature/non_decorator_transformations branch March 4, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants