📝 Add docstrings to feature/account-verification#580
Open
coderabbitai[bot] wants to merge 5 commits intodevfrom
Open
📝 Add docstrings to feature/account-verification#580coderabbitai[bot] wants to merge 5 commits intodevfrom
feature/account-verification#580coderabbitai[bot] wants to merge 5 commits intodevfrom
Conversation
- AccountVerification 엔티티 bankName → bankCode 필드명 변경 - 계좌번호 양방향 암호화 유틸리티(AesEncryptionUtil) 추가 - 암호화 관련 에러코드 추가 (ENCRYPTION_FAILED, DECRYPTION_FAILED) - Flyway 마이그레이션 V32 추가 (bank_name → bank_code) - 환경변수 설정 추가 (encryption.aes.secret-key) - 도메인 단위 테스트 추가
- AccountVerificationClient 인터페이스 정의 (String 반환) - TossAccountVerificationClient 구현체 추가 (현재 Fake 데이터 반환) - AccountVerificationService에 verifyAccount 메서드 추가 - VerifyAccountCommand, AccountVerificationInfo DTO 추가 - 서비스 단위 테스트 및 통합 테스트 추가
- POST /api/v1/seller/sellers/account-verifications 엔드포인트 추가 - AccountVerificationRequest DTO 추가 - Controller에서 Info 객체 직접 반환 (Response DTO 미사용) - Swagger 문서 작성 (@operation, @apiresponse)
Docstrings generation was requested by @kimbro97. * #579 (comment) The following files were modified: * `src/main/java/com/bbangle/bbangle/seller/domain/AccountVerification.java` * `src/main/java/com/bbangle/bbangle/seller/seller/controller/SellerController.java` * `src/main/java/com/bbangle/bbangle/seller/seller/controller/dto/SellerRequest.java` * `src/main/java/com/bbangle/bbangle/seller/seller/controller/swagger/SellerApi.java` * `src/main/java/com/bbangle/bbangle/seller/seller/service/AccountVerificationService.java` * `src/main/java/com/bbangle/bbangle/seller/seller/service/client/AccountVerificationClient.java` * `src/main/java/com/bbangle/bbangle/seller/seller/service/client/TossAccountVerificationClient.java` * `src/main/java/com/bbangle/bbangle/seller/seller/service/info/AccountVerificationInfo.java` * `src/main/java/com/bbangle/bbangle/util/AesEncryptionUtil.java`
Author
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. By default, CodeRabbit skips reviewing PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docstrings generation was requested by @kimbro97.
The following files were modified:
src/main/java/com/bbangle/bbangle/seller/domain/AccountVerification.javasrc/main/java/com/bbangle/bbangle/seller/seller/controller/SellerController.javasrc/main/java/com/bbangle/bbangle/seller/seller/controller/dto/SellerRequest.javasrc/main/java/com/bbangle/bbangle/seller/seller/controller/swagger/SellerApi.javasrc/main/java/com/bbangle/bbangle/seller/seller/service/AccountVerificationService.javasrc/main/java/com/bbangle/bbangle/seller/seller/service/client/AccountVerificationClient.javasrc/main/java/com/bbangle/bbangle/seller/seller/service/client/TossAccountVerificationClient.javasrc/main/java/com/bbangle/bbangle/seller/seller/service/info/AccountVerificationInfo.javasrc/main/java/com/bbangle/bbangle/util/AesEncryptionUtil.javaThese files were ignored
src/test/java/com/bbangle/bbangle/seller/domain/AccountVerificationUnitTest.javasrc/test/java/com/bbangle/bbangle/seller/seller/service/AccountVerificationServiceIntegrationTest.javasrc/test/java/com/bbangle/bbangle/seller/seller/service/AccountVerificationServiceUnitTest.javasrc/test/java/com/bbangle/bbangle/util/AesEncryptionUtilTest.javaThese file types are not supported
src/main/resources/application-dev.ymlsrc/main/resources/application-local.ymlsrc/main/resources/application-production.ymlsrc/main/resources/flyway/V32__app.sqlsrc/test/resources/application.ymlℹ️ Note