syncx(feat): 添加具有最大申请次数限制的Pool #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: longyue0521 <longyueli0521@gmail.com>
Signed-off-by: longyue0521 <longyueli0521@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #233 +/- ##
==========================================
- Coverage 95.91% 95.90% -0.01%
==========================================
Files 60 61 +1
Lines 3233 3250 +17
==========================================
+ Hits 3101 3117 +16
- Misses 102 104 +2
+ Partials 30 29 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: longyue0521 <longyueli0521@gmail.com>
Signed-off-by: longyue0521 <longyueli0521@gmail.com>
flycash
reviewed
Dec 24, 2023
之前提到的“一个用户请求,需要申请1MB缓冲区完成业务,看起来合理、问题也不大. 但是一段时间内大量并发用户申请的缓冲区的总量可能占用大量内存,从而影响到同一机器内的其他业务“ 所以需要控制住Pool的最大总内存占用量, 因为Pool中的对象都是通过new方法获得的,可以认为每个对象占用内存大致相等,那么控制住一段时间内的申请次数就相当于间接控制住Pool的最大总内存占用量. |
flycash
reviewed
Dec 24, 2023
flycash
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
通过控制一段时间内Pool的最大申请次数(可串行、可并行)来间接控制住Pool的最大使用量